ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: don’t use destructuring for props

Browse Source
This commit is contained in:
Philipp Kühn
2021-04-23 20:50:01 +02:00
parent 9110258a4c
commit 888cce2e4c
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/vue-3/src/BubbleMenu.ts
View File

@@ -27,10 +27,12 @@ export const BubbleMenu = defineComponent({
},
},
setup({ editor, tippyOptions }, { slots }) {
setup(props, { slots }) {
const root = ref<HTMLElement | null>(null)
onMounted(() => {
const { editor, tippyOptions } = props
editor.registerPlugin(BubbleMenuPlugin({
editor,
element: root.value as HTMLElement,
@@ -39,6 +41,8 @@ export const BubbleMenu = defineComponent({
})
onBeforeUnmount(() => {
const { editor } = props
editor.unregisterPlugin(BubbleMenuPluginKey)
})

6
packages/vue-3/src/FloatingMenu.ts
View File

@@ -27,10 +27,12 @@ export const FloatingMenu = defineComponent({
},
},
setup({ editor, tippyOptions }, { slots }) {
setup(props, { slots }) {
const root = ref<HTMLElement | null>(null)
onMounted(() => {
const { editor, tippyOptions } = props
editor.registerPlugin(FloatingMenuPlugin({
editor,
element: root.value as HTMLElement,
@@ -39,6 +41,8 @@ export const FloatingMenu = defineComponent({
})
onBeforeUnmount(() => {
const { editor } = props
editor.unregisterPlugin(FloatingMenuPluginKey)
})