From 888cce2e4c35e60c106c8aa65313ffeb1573e7e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= Date: Fri, 23 Apr 2021 20:50:01 +0200 Subject: [PATCH] =?UTF-8?q?refactor:=20don=E2=80=99t=20use=20destructuring?= =?UTF-8?q?=20for=20props?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/vue-3/src/BubbleMenu.ts | 6 +++++- packages/vue-3/src/FloatingMenu.ts | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/vue-3/src/BubbleMenu.ts b/packages/vue-3/src/BubbleMenu.ts index 0f2ffec1..c741b853 100644 --- a/packages/vue-3/src/BubbleMenu.ts +++ b/packages/vue-3/src/BubbleMenu.ts @@ -27,10 +27,12 @@ export const BubbleMenu = defineComponent({ }, }, - setup({ editor, tippyOptions }, { slots }) { + setup(props, { slots }) { const root = ref(null) onMounted(() => { + const { editor, tippyOptions } = props + editor.registerPlugin(BubbleMenuPlugin({ editor, element: root.value as HTMLElement, @@ -39,6 +41,8 @@ export const BubbleMenu = defineComponent({ }) onBeforeUnmount(() => { + const { editor } = props + editor.unregisterPlugin(BubbleMenuPluginKey) }) diff --git a/packages/vue-3/src/FloatingMenu.ts b/packages/vue-3/src/FloatingMenu.ts index 523e1057..31a53a4b 100644 --- a/packages/vue-3/src/FloatingMenu.ts +++ b/packages/vue-3/src/FloatingMenu.ts @@ -27,10 +27,12 @@ export const FloatingMenu = defineComponent({ }, }, - setup({ editor, tippyOptions }, { slots }) { + setup(props, { slots }) { const root = ref(null) onMounted(() => { + const { editor, tippyOptions } = props + editor.registerPlugin(FloatingMenuPlugin({ editor, element: root.value as HTMLElement, @@ -39,6 +41,8 @@ export const FloatingMenu = defineComponent({ }) onBeforeUnmount(() => { + const { editor } = props + editor.unregisterPlugin(FloatingMenuPluginKey) })