Merge pull request #1452 from YousefED/patch-2

use forwardRef for react wrappers
This commit is contained in:
Philipp Kühn
2021-06-14 16:02:45 +02:00
committed by GitHub
2 changed files with 33 additions and 28 deletions

View File

@@ -5,12 +5,14 @@ export interface NodeViewContentProps {
as?: React.ElementType,
}
export const NodeViewContent: React.FC<NodeViewContentProps> = props => {
export const NodeViewContent: React.FC<NodeViewContentProps> =
React.forwardRef((props, ref) => {
const Tag = props.as || 'div'
return (
<Tag
{...props}
ref={ref}
data-node-view-content=""
style={{
...props.style,
@@ -18,4 +20,5 @@ export const NodeViewContent: React.FC<NodeViewContentProps> = props => {
}}
/>
)
}
})

View File

@@ -6,13 +6,15 @@ export interface NodeViewWrapperProps {
as?: React.ElementType,
}
export const NodeViewWrapper: React.FC<NodeViewWrapperProps> = props => {
export const NodeViewWrapper: React.FC<NodeViewWrapperProps> =
React.forwardRef((props, ref) => {
const { onDragStart } = useReactNodeView()
const Tag = props.as || 'div'
return (
<Tag
{...props}
ref={ref}
data-node-view-wrapper=""
onDragStart={onDragStart}
style={{
@@ -21,4 +23,4 @@ export const NodeViewWrapper: React.FC<NodeViewWrapperProps> = props => {
}}
/>
)
}
})