From 83525ec4f1a5022d760cd6a95465eed6765110bc Mon Sep 17 00:00:00 2001 From: Yousef Date: Fri, 11 Jun 2021 08:04:53 +0200 Subject: [PATCH 1/4] NodeViewWrapper forwardRef --- packages/react/src/NodeViewWrapper.tsx | 31 ++++++++++++++------------ 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/packages/react/src/NodeViewWrapper.tsx b/packages/react/src/NodeViewWrapper.tsx index da502459..f69d9760 100644 --- a/packages/react/src/NodeViewWrapper.tsx +++ b/packages/react/src/NodeViewWrapper.tsx @@ -6,19 +6,22 @@ export interface NodeViewWrapperProps { as?: React.ElementType, } -export const NodeViewWrapper: React.FC = props => { - const { onDragStart } = useReactNodeView() - const Tag = props.as || 'div' +export const NodeViewWrapper: React.FC = + React.forwardRef((props, ref) => { + const { onDragStart } = useReactNodeView() + const Tag = props.as || 'div' - return ( - - ) + return ( + + ) + } } From deb79ea729cb43e55cb2a0877cdf381e70c6885e Mon Sep 17 00:00:00 2001 From: Yousef Date: Fri, 11 Jun 2021 08:06:44 +0200 Subject: [PATCH 2/4] NodeViewContent forwardRef --- packages/react/src/NodeViewContent.tsx | 27 ++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/packages/react/src/NodeViewContent.tsx b/packages/react/src/NodeViewContent.tsx index c06bc7d7..954493e0 100644 --- a/packages/react/src/NodeViewContent.tsx +++ b/packages/react/src/NodeViewContent.tsx @@ -5,17 +5,20 @@ export interface NodeViewContentProps { as?: React.ElementType, } -export const NodeViewContent: React.FC = props => { - const Tag = props.as || 'div' +export const NodeViewContent: React.FC = + React.forwardRef((props, ref) => { + const Tag = props.as || 'div' - return ( - - ) + return ( + + ) + } } From cc6bc0fa405c25b27d450aa269821e27e45b4b94 Mon Sep 17 00:00:00 2001 From: Yousef Date: Fri, 11 Jun 2021 08:33:22 +0200 Subject: [PATCH 3/4] Update NodeViewContent.tsx --- packages/react/src/NodeViewContent.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/NodeViewContent.tsx b/packages/react/src/NodeViewContent.tsx index 954493e0..5d867541 100644 --- a/packages/react/src/NodeViewContent.tsx +++ b/packages/react/src/NodeViewContent.tsx @@ -20,5 +20,5 @@ export const NodeViewContent: React.FC = }} /> ) - } -} + }) + From df8310407d5a62deeb9103d826c9807a1f033f20 Mon Sep 17 00:00:00 2001 From: Yousef Date: Fri, 11 Jun 2021 08:33:35 +0200 Subject: [PATCH 4/4] Update NodeViewWrapper.tsx --- packages/react/src/NodeViewWrapper.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/react/src/NodeViewWrapper.tsx b/packages/react/src/NodeViewWrapper.tsx index f69d9760..f50aa53f 100644 --- a/packages/react/src/NodeViewWrapper.tsx +++ b/packages/react/src/NodeViewWrapper.tsx @@ -23,5 +23,4 @@ export const NodeViewWrapper: React.FC = }} /> ) - } -} + })