ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #1452 from YousefED/patch-2

Browse Source 
use forwardRef for react wrappers
This commit is contained in:
Philipp Kühn
2021-06-14 16:02:45 +02:00
committed by GitHub
parent acd789be0a df8310407d
commit 55203d38eb
2 changed files with 33 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/react/src/NodeViewContent.tsx
View File

@@ -5,12 +5,14 @@ export interface NodeViewContentProps {
as?: React.ElementType, as?: React.ElementType,
} }
export const NodeViewContent: React.FC<NodeViewContentProps> = props => { export const NodeViewContent: React.FC<NodeViewContentProps> =
React.forwardRef((props, ref) => {
const Tag = props.as || 'div' const Tag = props.as || 'div'
return ( return (
<Tag <Tag
{...props} {...props}
ref={ref}
data-node-view-content="" data-node-view-content=""
style={{ style={{
...props.style, ...props.style,
@@ -18,4 +20,5 @@ export const NodeViewContent: React.FC<NodeViewContentProps> = props => {
}} }}
/> />
) )
} })

6
packages/react/src/NodeViewWrapper.tsx
View File

@@ -6,13 +6,15 @@ export interface NodeViewWrapperProps {
as?: React.ElementType, as?: React.ElementType,
} }
export const NodeViewWrapper: React.FC<NodeViewWrapperProps> = props => { export const NodeViewWrapper: React.FC<NodeViewWrapperProps> =
React.forwardRef((props, ref) => {
const { onDragStart } = useReactNodeView() const { onDragStart } = useReactNodeView()
const Tag = props.as || 'div' const Tag = props.as || 'div'
return ( return (
<Tag <Tag
{...props} {...props}
ref={ref}
data-node-view-wrapper="" data-node-view-wrapper=""
onDragStart={onDragStart} onDragStart={onDragStart}
style={{ style={{
@@ -21,4 +23,4 @@ export const NodeViewWrapper: React.FC<NodeViewWrapperProps> = props => {
}} }}
/> />
) )
} })