ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: Fix "destory" method in view plugins. (#1882)

Browse Source
This commit is contained in:
Kane Cohen
2021-09-22 12:28:52 +01:00
committed by GitHub
parent 39e1be59bb
commit 33420f4ae0
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/extension-bubble-menu/src/bubble-menu-plugin.ts
View File

@@ -190,7 +190,7 @@ export class BubbleMenuView {
destroy() { destroy() {
this.tippy?.destroy() this.tippy?.destroy()
this.element.removeEventListener('mousedown', this.mousedownHandler) this.element.removeEventListener('mousedown', this.mousedownHandler, { capture: true })
this.view.dom.removeEventListener('dragstart', this.dragstartHandler) this.view.dom.removeEventListener('dragstart', this.dragstartHandler)
this.editor.off('focus', this.focusHandler) this.editor.off('focus', this.focusHandler)
this.editor.off('blur', this.blurHandler) this.editor.off('blur', this.blurHandler)

2
packages/extension-floating-menu/src/floating-menu-plugin.ts
View File

@@ -160,7 +160,7 @@ export class FloatingMenuView {
destroy() { destroy() {
this.tippy?.destroy() this.tippy?.destroy()
this.element.removeEventListener('mousedown', this.mousedownHandler) this.element.removeEventListener('mousedown', this.mousedownHandler, { capture: true })
this.editor.off('focus', this.focusHandler) this.editor.off('focus', this.focusHandler)
this.editor.off('blur', this.blurHandler) this.editor.off('blur', this.blurHandler)
} }