From 33420f4ae06d0d7eec16201a2e650be83cbb9de9 Mon Sep 17 00:00:00 2001 From: Kane Cohen Date: Wed, 22 Sep 2021 12:28:52 +0100 Subject: [PATCH] fix: Fix "destory" method in view plugins. (#1882) --- packages/extension-bubble-menu/src/bubble-menu-plugin.ts | 2 +- packages/extension-floating-menu/src/floating-menu-plugin.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts index ba97303f..6b86f925 100644 --- a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts +++ b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts @@ -190,7 +190,7 @@ export class BubbleMenuView { destroy() { this.tippy?.destroy() - this.element.removeEventListener('mousedown', this.mousedownHandler) + this.element.removeEventListener('mousedown', this.mousedownHandler, { capture: true }) this.view.dom.removeEventListener('dragstart', this.dragstartHandler) this.editor.off('focus', this.focusHandler) this.editor.off('blur', this.blurHandler) diff --git a/packages/extension-floating-menu/src/floating-menu-plugin.ts b/packages/extension-floating-menu/src/floating-menu-plugin.ts index 7fdd21b2..f6da5655 100644 --- a/packages/extension-floating-menu/src/floating-menu-plugin.ts +++ b/packages/extension-floating-menu/src/floating-menu-plugin.ts @@ -160,7 +160,7 @@ export class FloatingMenuView { destroy() { this.tippy?.destroy() - this.element.removeEventListener('mousedown', this.mousedownHandler) + this.element.removeEventListener('mousedown', this.mousedownHandler, { capture: true }) this.editor.off('focus', this.focusHandler) this.editor.off('blur', this.blurHandler) }