From fd94e321eaa1d8557b0a14c47c51ff36bb40ad89 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Wed, 25 Nov 2020 17:58:53 +0100
Subject: [PATCH] cleanup drag handle example

---
 .../demos/Examples/DragHandle/Component.vue   | 57 ++++++++++++++
 .../Test.ts => DragHandle/DraggableItem.js}   |  7 +-
 .../{NodeView => DragHandle}/index.vue        | 45 ++++-------
 .../src/demos/Examples/NodeView/Component.vue | 78 -------------------
 docs/src/demos/Examples/VModel/index.vue      |  2 +-
 docs/src/docPages/examples/drag-handle.md     |  2 +-
 docs/src/docPages/examples/node-view.md       |  3 -
 docs/src/links.yaml                           |  3 +
 packages/vue/src/VueRenderer.ts               |  1 +
 9 files changed, 80 insertions(+), 118 deletions(-)
 create mode 100644 docs/src/demos/Examples/DragHandle/Component.vue
 rename docs/src/demos/Examples/{NodeView/Test.ts => DragHandle/DraggableItem.js} (85%)
 rename docs/src/demos/Examples/{NodeView => DragHandle}/index.vue (61%)
 delete mode 100644 docs/src/demos/Examples/NodeView/Component.vue
 delete mode 100644 docs/src/docPages/examples/node-view.md

diff --git a/docs/src/demos/Examples/DragHandle/Component.vue b/docs/src/demos/Examples/DragHandle/Component.vue
new file mode 100644
index 00000000..229bcf00
--- /dev/null
+++ b/docs/src/demos/Examples/DragHandle/Component.vue
@@ -0,0 +1,57 @@
+<template>
+  <node-view-wrapper class="draggable-item">
+    <div class="drag-handle" contenteditable="false" data-drag-handle />
+    <node-view-content class="content" />
+  </node-view-wrapper>
+</template>
+
+<script>
+export default {
+  props: {
+    editor: {
+      type: Object,
+      required: true,
+    },
+
+    node: {
+      type: Object,
+      required: true,
+    },
+
+    updateAttributes: {
+      type: Function,
+      required: true,
+    },
+  },
+}
+</script>
+
+<style lang="scss" scoped>
+.draggable-item {
+  display: flex;
+  padding: 0.5rem;
+  margin: 0.5rem 0;
+  border-radius: 0.5rem;
+  box-shadow:
+    0 0 0 1px rgba(0, 0, 0, 0.1),
+    0px 10px 20px rgba(0, 0, 0, 0.1),
+  ;
+
+  .drag-handle {
+    position: relative;
+    width: 1rem;
+    height: 1rem;
+    top: 0.3rem;
+    margin-right: 0.5rem;
+    cursor: grab;
+    background-image: url('data:image/svg+xml;charset=UTF-8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 16"><path fill-opacity="0.2" d="M4 14c0 1.1-.9 2-2 2s-2-.9-2-2 .9-2 2-2 2 .9 2 2zM2 6C.9 6 0 6.9 0 8s.9 2 2 2 2-.9 2-2-.9-2-2-2zm0-6C.9 0 0 .9 0 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm6 4c1.1 0 2-.9 2-2s-.9-2-2-2-2 .9-2 2 .9 2 2 2zm0 2c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm0 6c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2z" /></svg>');
+    background-repeat: no-repeat;
+    background-size: contain;
+    background-position: center;
+  }
+
+  .content {
+    flex: 1 1 auto;
+  }
+}
+</style>
diff --git a/docs/src/demos/Examples/NodeView/Test.ts b/docs/src/demos/Examples/DragHandle/DraggableItem.js
similarity index 85%
rename from docs/src/demos/Examples/NodeView/Test.ts
rename to docs/src/demos/Examples/DragHandle/DraggableItem.js
index 15d956e8..6f289e50 100644
--- a/docs/src/demos/Examples/NodeView/Test.ts
+++ b/docs/src/demos/Examples/DragHandle/DraggableItem.js
@@ -3,11 +3,10 @@ import { VueRenderer } from '@tiptap/vue'
 import Component from './Component.vue'
 
 export default Node.create({
-  name: 'test',
+  name: 'draggableItem',
 
   group: 'block',
 
-  // content: 'inline*',
   content: 'block*',
 
   draggable: true,
@@ -25,13 +24,13 @@ export default Node.create({
   parseHTML() {
     return [
       {
-        tag: 'div[data-type="test"]',
+        tag: 'div[data-type="draggable-item"]',
       },
     ]
   },
 
   renderHTML({ HTMLAttributes }) {
-    return ['div', mergeAttributes(HTMLAttributes, { 'data-type': 'test' }), 0]
+    return ['div', mergeAttributes(HTMLAttributes, { 'data-type': 'draggable-item' }), 0]
   },
 
   addNodeView() {
diff --git a/docs/src/demos/Examples/NodeView/index.vue b/docs/src/demos/Examples/DragHandle/index.vue
similarity index 61%
rename from docs/src/demos/Examples/NodeView/index.vue
rename to docs/src/demos/Examples/DragHandle/index.vue
index 94910bf6..24ffb012 100644
--- a/docs/src/demos/Examples/NodeView/index.vue
+++ b/docs/src/demos/Examples/DragHandle/index.vue
@@ -7,11 +7,11 @@
 <script>
 import { Editor } from '@tiptap/core'
 import { EditorContent } from '@tiptap/vue'
-import Dropcursor from '@tiptap/extension-dropcursor'
 import Document from '@tiptap/extension-document'
 import Paragraph from '@tiptap/extension-paragraph'
 import Text from '@tiptap/extension-text'
-import Test from './Test.ts'
+import Dropcursor from '@tiptap/extension-dropcursor'
+import DraggableItem from './DraggableItem.js'
 
 export default {
   components: {
@@ -27,28 +27,28 @@ export default {
   mounted() {
     this.editor = new Editor({
       extensions: [
-        Dropcursor,
         Document,
         Paragraph,
         Text,
-        Test,
+        Dropcursor,
+        DraggableItem,
       ],
       content: `
         <p>paragraph</p>
-        <div data-type="test">
-          <p>paragraph</p>
-          <div data-type="test">
-            <p>paragraph</p>
-          </div>
+        <div data-type="draggable-item">
+          <p>draggable item</p>
         </div>
-        <div data-type="test">
-          <p>paragraph</p>
+        <div data-type="draggable-item">
+          <p>another one</p>
+          <div data-type="draggable-item">
+            <p>can be nested too</p>
+            <div data-type="draggable-item">
+              <p>but can we go deeper?</p>
+            </div>
+          </div>
         </div>
         <p>paragraph</p>
       `,
-      onUpdate: () => {
-        console.log(this.editor.getHTML())
-      },
     })
   },
 
@@ -57,20 +57,3 @@ export default {
   },
 }
 </script>
-
-<style lang="scss">
-ul[data-type="taskList"] {
-  list-style: none;
-  padding: 0;
-
-  li {
-    display: flex;
-    align-items: center;
-
-    > input {
-      flex: 0 0 auto;
-      margin-right: 0.5rem;
-    }
-  }
-}
-</style>
diff --git a/docs/src/demos/Examples/NodeView/Component.vue b/docs/src/demos/Examples/NodeView/Component.vue
deleted file mode 100644
index dd3c814f..00000000
--- a/docs/src/demos/Examples/NodeView/Component.vue
+++ /dev/null
@@ -1,78 +0,0 @@
-<template>
-  <node-view-wrapper class="item">
-    <!-- <button @click="toggleChecked" contenteditable="false">
-      toggle checked
-    </button>
-    <div contenteditable="false">
-      checked: {{ node.attrs.checked }}
-    </div> -->
-
-    <div data-drag-handle class="drag-handle" contenteditable="false" />
-    <node-view-content />
-  </node-view-wrapper>
-</template>
-
-<script>
-export default {
-  props: {
-    editor: {
-      type: Object,
-      required: true,
-    },
-
-    node: {
-      type: Object,
-      required: true,
-    },
-
-    updateAttributes: {
-      type: Function,
-      required: true,
-    },
-  },
-
-  data() {
-    return {
-      // random: 'foo',
-    }
-  },
-
-  methods: {
-    toggleChecked() {
-      // this.editor.commands.focus()
-      this.updateAttributes({
-        checked: !this.node.attrs.checked,
-      })
-    },
-  },
-
-  mounted() {
-    console.log('MOUNTED')
-    // setInterval(() => {
-    //   this.random = `foo${Math.random()}`
-    // }, 1000)
-  },
-}
-</script>
-
-<style lang="scss">
-.item {
-  padding: 0.5rem;
-  margin: 1rem 0;
-  border-radius: 0.5rem;
-  box-shadow:
-    0 0 0 1px rgba(0, 0, 0, 0.1),
-    0px 10px 20px rgba(0, 0, 0, 0.1),
-  ;
-}
-
-.drag-handle {
-  width: 1rem;
-  height: 1rem;
-  cursor: grab;
-  background-image: url('data:image/svg+xml;charset=UTF-8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 16"><path fill-opacity="0.4" d="M4 14c0 1.1-.9 2-2 2s-2-.9-2-2 .9-2 2-2 2 .9 2 2zM2 6C.9 6 0 6.9 0 8s.9 2 2 2 2-.9 2-2-.9-2-2-2zm0-6C.9 0 0 .9 0 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm6 4c1.1 0 2-.9 2-2s-.9-2-2-2-2 .9-2 2 .9 2 2 2zm0 2c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm0 6c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2z" /></svg>');
-  background-repeat: no-repeat;
-  background-size: contain;
-  background-position: center;
-}
-</style>
diff --git a/docs/src/demos/Examples/VModel/index.vue b/docs/src/demos/Examples/VModel/index.vue
index 74fe1f07..9b173776 100644
--- a/docs/src/demos/Examples/VModel/index.vue
+++ b/docs/src/demos/Examples/VModel/index.vue
@@ -25,7 +25,7 @@ export default {
 }
 </script>
 
-<style lang="scss">
+<style lang="scss" scoped>
 .content {
   padding: 1rem 0 0;
 
diff --git a/docs/src/docPages/examples/drag-handle.md b/docs/src/docPages/examples/drag-handle.md
index b84ed0e3..858f193f 100644
--- a/docs/src/docPages/examples/drag-handle.md
+++ b/docs/src/docPages/examples/drag-handle.md
@@ -1,3 +1,3 @@
 # Drag Handle
 
-<demo name="Examples/DragHandle" />
\ No newline at end of file
+<demo name="Examples/DragHandle" />
diff --git a/docs/src/docPages/examples/node-view.md b/docs/src/docPages/examples/node-view.md
deleted file mode 100644
index 1040abeb..00000000
--- a/docs/src/docPages/examples/node-view.md
+++ /dev/null
@@ -1,3 +0,0 @@
-# Node View
-
-<demo name="Examples/NodeView" />
diff --git a/docs/src/links.yaml b/docs/src/links.yaml
index b027fd36..0e18ee3c 100644
--- a/docs/src/links.yaml
+++ b/docs/src/links.yaml
@@ -34,6 +34,9 @@
           link: /examples/minimalist
         - title: Use with v-model
           link: /examples/v-model
+        - title: Drag handle
+          link: /examples/drag-handle
+          draft: true
         - title: Export HTML or JSON
           link: /examples/export-html-or-json
     - title: Feedback
diff --git a/packages/vue/src/VueRenderer.ts b/packages/vue/src/VueRenderer.ts
index 160c7cec..adfb39d3 100644
--- a/packages/vue/src/VueRenderer.ts
+++ b/packages/vue/src/VueRenderer.ts
@@ -71,6 +71,7 @@ class VueNodeView implements NodeView {
       return
     }
 
+    // sometimes `event.target` is not the `dom` element
     event.dataTransfer?.setDragImage(this.dom, 0, 0)
 
     const selection = NodeSelection.create(view.state.doc, this.getPos())