fix: improve performance for isActive method, see #1930

2021-09-22 19:43:55 +02:00
parent 6fa886273f
commit fcca1e6f4d
5 changed files with 14 additions and 14 deletions
--- a/packages/core/src/helpers/getNodeAttributes.ts
+++ b/packages/core/src/helpers/getNodeAttributes.ts
@@ -5,10 +5,10 @@ import getNodeType from './getNodeType'
 export default function getNodeAttributes(state: EditorState, typeOrName: string | NodeType): Record<string, any> {
  const type = getNodeType(typeOrName, state.schema)
  const { from, to } = state.selection
-  let nodes: Node[] = []
+  const nodes: Node[] = []

  state.doc.nodesBetween(from, to, node => {
-    nodes = [...nodes, node]
+    nodes.push(node)
  })

  const node = nodes