ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: Check node type above custom update function for node views (#2081)

Browse Source
This commit is contained in:
Jon Noronha
2021-10-25 00:52:34 -07:00
committed by GitHub
parent 45778b81dd
commit ddc9ca8d4f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/react/src/ReactNodeViewRenderer.tsx
View File

@@ -114,6 +114,10 @@ class ReactNodeView extends NodeView<React.FunctionComponent, Editor, ReactNodeV
this.renderer.updateProps(props) this.renderer.updateProps(props)
} }
if (node.type !== this.node.type) {
return false
}
if (typeof this.options.update === 'function') { if (typeof this.options.update === 'function') {
const oldNode = this.node const oldNode = this.node
const oldDecorations = this.decorations const oldDecorations = this.decorations
@@ -130,10 +134,6 @@ class ReactNodeView extends NodeView<React.FunctionComponent, Editor, ReactNodeV
}) })
} }
if (node.type !== this.node.type) {
return false
}
if (node === this.node && this.decorations === decorations) { if (node === this.node && this.decorations === decorations) {
return true return true
} }