From ddc9ca8d4f347566f83513a386922afe52f26da1 Mon Sep 17 00:00:00 2001
From: Jon Noronha <jon@gamma.app>
Date: Mon, 25 Oct 2021 00:52:34 -0700
Subject: [PATCH] fix: Check node type above custom update function for node
 views (#2081)

---
 packages/react/src/ReactNodeViewRenderer.tsx | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/react/src/ReactNodeViewRenderer.tsx b/packages/react/src/ReactNodeViewRenderer.tsx
index e13945f2..6d21e02c 100644
--- a/packages/react/src/ReactNodeViewRenderer.tsx
+++ b/packages/react/src/ReactNodeViewRenderer.tsx
@@ -114,6 +114,10 @@ class ReactNodeView extends NodeView<React.FunctionComponent, Editor, ReactNodeV
       this.renderer.updateProps(props)
     }
 
+    if (node.type !== this.node.type) {
+      return false
+    }
+
     if (typeof this.options.update === 'function') {
       const oldNode = this.node
       const oldDecorations = this.decorations
@@ -130,10 +134,6 @@ class ReactNodeView extends NodeView<React.FunctionComponent, Editor, ReactNodeV
       })
     }
 
-    if (node.type !== this.node.type) {
-      return false
-    }
-
     if (node === this.node && this.decorations === decorations) {
       return true
     }