From dbebb1ca9ef84061984fbd0ef35c7869b87cca87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= Date: Wed, 25 Nov 2020 23:19:23 +0100 Subject: [PATCH] check isEditable in node view renderer --- packages/vue/src/VueRenderer.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/vue/src/VueRenderer.ts b/packages/vue/src/VueRenderer.ts index 90542623..3212f62c 100644 --- a/packages/vue/src/VueRenderer.ts +++ b/packages/vue/src/VueRenderer.ts @@ -93,6 +93,7 @@ class VueNodeView implements NodeView { createNodeViewContent() { const { id } = this + const { isEditable } = this.editor return Vue.extend({ inheritAttrs: false, @@ -110,7 +111,7 @@ class VueNodeView implements NodeView { }, attrs: { id, - contenteditable: true, + contenteditable: isEditable, }, }, ) @@ -175,6 +176,7 @@ class VueNodeView implements NodeView { return false } + const { isEditable } = this.editor const isDraggable = this.node.type.spec.draggable const isCopyEvent = event.type === 'copy' const isPasteEvent = event.type === 'paste' @@ -187,7 +189,7 @@ class VueNodeView implements NodeView { } // we have to store that dragging started - if (isDraggable && !this.isDragging && event.type === 'mousedown') { + if (isDraggable && isEditable && !this.isDragging && event.type === 'mousedown') { const dragHandle = target.closest('[data-drag-handle]') const isValidDragHandle = dragHandle && (this.dom === dragHandle || (this.dom.contains(dragHandle)))