refactoring

packages/core/src/utils/getSchema.ts

@@ -1,5 +1,7 @@
-import { NodeSpec, MarkSpec, Schema } from 'prosemirror-model'
-import { Extensions } from '../types'
+import {
+  NodeSpec, MarkSpec, Schema, ParseRule,
+} from 'prosemirror-model'
+import { ExtensionAttribute, Extensions } from '../types'
 import splitExtensions from './splitExtensions'
 import getAttributesFromExtensions from './getAttributesFromExtensions'
 import getRenderedAttributes from './getRenderedAttributes'
@@ -15,33 +17,7 @@ function cleanUpSchemaItem<T>(data: T) {
   })) as T
 }
 
-export default function getSchema(extensions: Extensions): Schema {
-  const allAttributes = getAttributesFromExtensions(extensions)
-  const { nodeExtensions, markExtensions } = splitExtensions(extensions)
-  const topNode = nodeExtensions.find(extension => extension.topNode)?.name
-
-  const nodes = Object.fromEntries(nodeExtensions.map(extension => {
-    const context = {
-      options: extension.options,
-    }
-
-    const extensionAttributes = allAttributes.filter(attribute => attribute.type === extension.name)
-
-    const schema: NodeSpec = cleanUpSchemaItem({
-      content: extension.content,
-      marks: extension.marks,
-      group: extension.group,
-      inline: extension.inline,
-      atom: extension.atom,
-      selectable: extension.selectable,
-      draggable: extension.draggable,
-      code: extension.code,
-      defining: extension.defining,
-      isolating: extension.isolating,
-      attrs: Object.fromEntries(extensionAttributes.map(extensionAttribute => {
-        return [extensionAttribute.name, { default: extensionAttribute?.attribute?.default }]
-      })),
-      parseDOM: extension.parseHTML.bind(context)()?.map(parseRule => {
+function injectExtensionAttributes(parseRule: ParseRule, extensionAttributes: ExtensionAttribute[]): ParseRule {
   if (parseRule.style) {
     return parseRule
   }
@@ -60,27 +36,51 @@ export default function getSchema(extensions: Extensions): Schema {
       return { ...oldAttributes, ...newAttributes }
     },
   }
-      }),
-      ...(typeof extension.renderHTML === 'function') && {
-        toDOM: node => {
-          return (extension.renderHTML as Function).bind(context)({
+}
+
+export default function getSchema(extensions: Extensions): Schema {
+  const allAttributes = getAttributesFromExtensions(extensions)
+  const { nodeExtensions, markExtensions } = splitExtensions(extensions)
+  const topNode = nodeExtensions.find(extension => extension.topNode)?.name
+
+  const nodes = Object.fromEntries(nodeExtensions.map(extension => {
+    const extensionAttributes = allAttributes.filter(attribute => attribute.type === extension.name)
+    const context = { options: extension.options }
+    const schema: NodeSpec = cleanUpSchemaItem({
+      content: extension.content,
+      marks: extension.marks,
+      group: extension.group,
+      inline: extension.inline,
+      atom: extension.atom,
+      selectable: extension.selectable,
+      draggable: extension.draggable,
+      code: extension.code,
+      defining: extension.defining,
+      isolating: extension.isolating,
+      attrs: Object.fromEntries(extensionAttributes.map(extensionAttribute => {
+        return [extensionAttribute.name, { default: extensionAttribute?.attribute?.default }]
+      })),
+    })
+
+    if (extension.parseHTML) {
+      schema.parseDOM = extension.parseHTML
+        .bind(context)()
+        ?.map(parseRule => injectExtensionAttributes(parseRule, extensionAttributes))
+    }
+
+    if (extension.renderHTML) {
+      schema.toDOM = node => (extension.renderHTML as Function)?.bind(context)({
         node,
         attributes: getRenderedAttributes(node, extensionAttributes),
       })
-        },
-      },
-    })
+    }
 
     return [extension.name, schema]
   }))
 
   const marks = Object.fromEntries(markExtensions.map(extension => {
-    const context = {
-      options: extension.options,
-    }
-
     const extensionAttributes = allAttributes.filter(attribute => attribute.type === extension.name)
-
+    const context = { options: extension.options }
     const schema: MarkSpec = cleanUpSchemaItem({
       inclusive: extension.inclusive,
       excludes: extension.excludes,
@@ -89,16 +89,20 @@ export default function getSchema(extensions: Extensions): Schema {
       attrs: Object.fromEntries(extensionAttributes.map(extensionAttribute => {
         return [extensionAttribute.name, { default: extensionAttribute?.attribute?.default }]
       })),
-      parseDOM: extension.parseHTML.bind(context)(),
-      ...(typeof extension.renderHTML === 'function') && {
-        toDOM: mark => {
-          return (extension.renderHTML as Function).bind(context)({
+    })
+
+    if (extension.parseHTML) {
+      schema.parseDOM = extension.parseHTML
+        .bind(context)()
+        ?.map(parseRule => injectExtensionAttributes(parseRule, extensionAttributes))
+    }
+
+    if (extension.renderHTML) {
+      schema.toDOM = mark => (extension.renderHTML as Function)?.bind(context)({
         mark,
         attributes: getRenderedAttributes(mark, extensionAttributes),
       })
-        },
-      },
-    })
+    }
 
     return [extension.name, schema]
   }))