ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix bug in suggestion extension, fix #143

Browse Source
This commit is contained in:
Philipp Kühn
2021-02-07 20:00:13 +01:00
parent 7d15e5afb9
commit aef0acf53d
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/suggestion/src/findSuggestionMatch.ts
View File

@@ -38,9 +38,9 @@ export function findSuggestionMatch(config: Trigger): SuggestionMatch {
const textFrom = $position.before() const textFrom = $position.before()
const textTo = $position.pos const textTo = $position.pos
const text = $position.doc.textBetween(textFrom, textTo, '\0', '\0') const text = $position.doc.textBetween(textFrom, textTo, '\0', '\0')
const match = regexp.exec(text) const match = Array.from(text.matchAll(regexp)).pop()
if (!match) { if (!match || match.input === undefined || match.index === undefined) {
return null return null
} }

8
packages/suggestion/src/suggestion.ts
View File

@@ -101,16 +101,16 @@ export function Suggestion({
clientRect: () => decorationNode?.getBoundingClientRect() || null, clientRect: () => decorationNode?.getBoundingClientRect() || null,
} }
if (handleStart) { if (handleExit) {
renderer?.onStart?.(props) renderer?.onExit?.(props)
} }
if (handleChange) { if (handleChange) {
renderer?.onUpdate?.(props) renderer?.onUpdate?.(props)
} }
if (handleExit) { if (handleStart) {
renderer?.onExit?.(props) renderer?.onStart?.(props)
} }
}, },
} }