From ac9fdf64811d85826a03d2ca733eea2e73ca5988 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Sun, 25 Oct 2020 22:11:53 +0100
Subject: [PATCH] refactor link extension

---
 packages/core/index.ts                     |  1 +
 packages/core/src/utils/mergeAttributes.ts | 34 ++++++++++---------
 packages/extension-link/index.ts           | 39 +++++++++++-----------
 3 files changed, 38 insertions(+), 36 deletions(-)

diff --git a/packages/core/index.ts b/packages/core/index.ts
index 70f84a8b..1eb42fff 100644
--- a/packages/core/index.ts
+++ b/packages/core/index.ts
@@ -18,3 +18,4 @@ export { default as getSchema } from './src/utils/getSchema'
 export { default as generateHtml } from './src/utils/generateHtml'
 export { default as getHtmlFromFragment } from './src/utils/getHtmlFromFragment'
 export { default as getMarkAttrs } from './src/utils/getMarkAttrs'
+export { default as mergeAttributes } from './src/utils/mergeAttributes'
diff --git a/packages/core/src/utils/mergeAttributes.ts b/packages/core/src/utils/mergeAttributes.ts
index d19fe8ab..136e3c5b 100644
--- a/packages/core/src/utils/mergeAttributes.ts
+++ b/packages/core/src/utils/mergeAttributes.ts
@@ -1,23 +1,25 @@
 import { AnyObject } from '../types'
 
-export default function mergeAttributes(attributes1: AnyObject, attributes2: AnyObject) {
-  const mergedAttributes = { ...attributes1 }
+export default function mergeAttributes(...object: AnyObject[]) {
+  return object.reduce((items, item) => {
+    const mergedAttributes = { ...items }
 
-  Object.entries(attributes2).forEach(([key, value]) => {
-    if (!mergedAttributes[key]) {
-      mergedAttributes[key] = value
-      return
-    }
+    Object.entries(item).forEach(([key, value]) => {
+      if (!mergedAttributes[key]) {
+        mergedAttributes[key] = value
+        return
+      }
 
-    if (key === 'class') {
-      mergedAttributes[key] = [mergedAttributes[key], value].join(' ')
-      return
-    }
+      if (key === 'class') {
+        mergedAttributes[key] = [mergedAttributes[key], value].join(' ')
+        return
+      }
 
-    if (key === 'style') {
-      mergedAttributes[key] = [mergedAttributes[key], value].join('; ')
-    }
-  })
+      if (key === 'style') {
+        mergedAttributes[key] = [mergedAttributes[key], value].join('; ')
+      }
+    })
 
-  return mergedAttributes
+    return mergedAttributes
+  }, {})
 }
diff --git a/packages/extension-link/index.ts b/packages/extension-link/index.ts
index 4a95ff21..40659e34 100644
--- a/packages/extension-link/index.ts
+++ b/packages/extension-link/index.ts
@@ -1,4 +1,6 @@
-import { Command, createMark, markPasteRule } from '@tiptap/core'
+import {
+  Command, createMark, markPasteRule, mergeAttributes,
+} from '@tiptap/core'
 import { Plugin, PluginKey } from 'prosemirror-state'
 
 export interface LinkOptions {
@@ -24,34 +26,31 @@ const Link = createMark({
     return {
       href: {
         default: null,
-        rendered: false,
+        renderHTML: attributes => ({
+          href: attributes.href,
+        }),
+        parseHTML: node => ({
+          href: node.getAttribute('href'),
+        }),
       },
       target: {
-        default: null,
-        rendered: false,
+        default: this.options.target,
+        renderHTML: attributes => ({
+          target: attributes.target,
+        }),
+        parseHTML: node => ({
+          target: node.getAttribute('target'),
+        }),
       },
     }
   },
 
   parseHTML() {
-    return [
-      {
-        tag: 'a[href]',
-        getAttrs: node => ({
-          href: (node as HTMLElement).getAttribute('href'),
-          target: (node as HTMLElement).getAttribute('target'),
-        }),
-      },
-    ]
+    return [{ tag: 'a[href]' }]
   },
 
-  renderHTML({ mark, attributes }) {
-    return ['a', {
-      ...attributes,
-      ...mark.attrs,
-      rel: this.options.rel,
-      target: mark.attrs.target ? mark.attrs.target : this.options.target,
-    }, 0]
+  renderHTML({ attributes }) {
+    return ['a', mergeAttributes(attributes, { rel: this.options.rel }), 0]
   },
 
   addCommands() {