From a60a851fc4005315cd12714cfbac01323a6932c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Fri, 28 Sep 2018 13:46:39 +0200
Subject: [PATCH] improve styling

---
 examples/Components/Routes/Mentions/index.vue | 29 ++++++++++++++++---
 .../tiptap-extensions/src/nodes/Mention.js    |  2 +-
 .../src/plugins/suggestions.js                |  4 +--
 3 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/examples/Components/Routes/Mentions/index.vue b/examples/Components/Routes/Mentions/index.vue
index a06d5d1b..15e71551 100644
--- a/examples/Components/Routes/Mentions/index.vue
+++ b/examples/Components/Routes/Mentions/index.vue
@@ -13,8 +13,8 @@
 
 		</editor>
 
-		<div class="suggestions">
-			<div v-if="query && !filteredUsers.length">
+		<div class="suggestion-list" v-if="query || filteredUsers.length">
+			<div class="suggestion-list__no-results" v-if="query && !filteredUsers.length">
 				No users found.
 			</div>
 			<div
@@ -22,7 +22,7 @@
 				v-for="(user, index) in filteredUsers"
 				:key="user.id"
 				@click="selectUser(user)"
-				class="suggestions__item"
+				class="suggestion-list__item"
 				:class="{ 'is-selected': navigatedUserIndex === index }"
 			>
 				{{ user.name }}
@@ -158,13 +158,34 @@ export default {
   font-weight: bold;
   border-radius: 5px;
   padding: 0.2rem 0.5rem;
+	white-space: nowrap;
 }
 
-.suggestions {
+.mention-suggestion {
+	color: rgba($color-black, 0.6);
+}
+
+.suggestion-list {
 	max-width: 30rem;
 	margin: 0 auto 2rem auto;
+	padding: 0.2rem;
+	border-radius: 5px;
+	border: 2px solid rgba($color-black, 0.1);
+	color: rgba($color-black, 0.6);
+	font-size: 0.8rem;
+	font-weight: bold;
+
+	&__no-results {
+		padding: 0.2rem 0.5rem;
+	}
 
 	&__item {
+		color: rgba($color-black, 0.6);
+		font-size: 0.8rem;
+		font-weight: bold;
+		border-radius: 5px;
+		padding: 0.2rem 0.5rem;
+
 		&.is-selected {
 			background-color: rgba($color-black, 0.1);
 		}
diff --git a/packages/tiptap-extensions/src/nodes/Mention.js b/packages/tiptap-extensions/src/nodes/Mention.js
index 95b2e10f..de3e6842 100644
--- a/packages/tiptap-extensions/src/nodes/Mention.js
+++ b/packages/tiptap-extensions/src/nodes/Mention.js
@@ -45,7 +45,7 @@ export default class MentionNode extends Node {
 	get plugins() {
 		return [
 			suggestionsPlugin({
-				debug: true,
+				suggestionClass: 'mention-suggestion',
 				matcher: triggerCharacter('@', {
 					allowSpaces: false,
 					startOfLine: false,
diff --git a/packages/tiptap-extensions/src/plugins/suggestions.js b/packages/tiptap-extensions/src/plugins/suggestions.js
index 68ee7785..834efe07 100644
--- a/packages/tiptap-extensions/src/plugins/suggestions.js
+++ b/packages/tiptap-extensions/src/plugins/suggestions.js
@@ -66,7 +66,7 @@ export function triggerCharacter(char, { allowSpaces = false, startOfLine = fals
  */
 export function suggestionsPlugin({
   matcher = triggerCharacter('#'),
-  suggestionClass = 'ProseMirror-suggestion',
+  suggestionClass = 'suggestion',
   command = () => false,
   items = [],
   onEnter = () => false,
@@ -81,7 +81,6 @@ export function suggestionsPlugin({
     return searchItems
       .filter(item => JSON.stringify(item).toLowerCase().includes(query.toLowerCase()))
   },
-  debug = false,
 }) {
   return new Plugin({
     key: new PluginKey('suggestions'),
@@ -241,7 +240,6 @@ export function suggestionsPlugin({
             nodeName: 'span',
             class: suggestionClass,
             'data-decoration-id': decorationId,
-            style: debug ? 'background: rgba(0, 0, 255, 0.05); color: blue; border: 2px solid blue;' : null,
           }),
         ])
       },