From 9a1bc8a8b1f2f86bfa695a41af79ec2d32c0e1d9 Mon Sep 17 00:00:00 2001
From: Hans Pagel <hans.pagel@ueber.io>
Date: Mon, 12 Oct 2020 17:58:30 +0200
Subject: [PATCH] everything is broken

---
 docs/src/demos/Extensions/Highlight/index.vue | 9 +++++++++
 packages/core/src/utils/markHasAttributes.ts  | 8 ++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/docs/src/demos/Extensions/Highlight/index.vue b/docs/src/demos/Extensions/Highlight/index.vue
index d52c6790..aed1d5d7 100644
--- a/docs/src/demos/Extensions/Highlight/index.vue
+++ b/docs/src/demos/Extensions/Highlight/index.vue
@@ -1,5 +1,11 @@
 <template>
   <div v-if="editor">
+    <button
+      @click="editor.chain().focus().highlight().run()"
+      :class="{ 'is-active': editor.isActive('highlight') }"
+    >
+      highlight (any)
+    </button>
     <button
       @click="editor.chain().focus().highlight({
         color: ''
@@ -10,6 +16,9 @@
     >
       highlight (default)
     </button>
+    <button @click="editor.chain().focus().highlight({ color: 'red' }).run()" :class="{ 'is-active': editor.isActive('highlight', { color: 'red' }) }">
+      "red"
+    </button>
     <button @click="editor.chain().focus().highlight({ color: '#ffa8a8' }).run()" :class="{ 'is-active': editor.isActive('highlight', { color: '#ffa8a8' }) }">
       red
     </button>
diff --git a/packages/core/src/utils/markHasAttributes.ts b/packages/core/src/utils/markHasAttributes.ts
index a598c26c..0c22314c 100644
--- a/packages/core/src/utils/markHasAttributes.ts
+++ b/packages/core/src/utils/markHasAttributes.ts
@@ -2,14 +2,18 @@ import { EditorState } from 'prosemirror-state'
 import { MarkType } from 'prosemirror-model'
 import getMarkAttrs from './getMarkAttrs'
 
-export default function markHasAttributes(state: EditorState, type: MarkType, attrs?: { [key: string]: any }) {
-  if (attrs === undefined) {
+export default function markHasAttributes(state: EditorState, type: MarkType, attrs?: { [key: string]: any }): boolean {
+  // @ts-ignore
+  if (attrs === undefined || Object.keys(attrs).length === 0) {
     return true
   }
 
   const originalAttrs: { [key: string]: any } = getMarkAttrs(state, type)
 
+  // @ts-ignore
   return Object.keys(attrs).filter((key: string) => {
+    // @ts-ignore
+    console.log(attrs[key], originalAttrs[key], attrs[key] === originalAttrs[key])
     return attrs[key] === originalAttrs[key]
   }).length
 }