ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix endPosition in getMarkRange

Browse Source 
getMarkRange() will not return the actual end position of the current mark.

might reintroduce bug from #156 (i cannot reproduce #156 so i cannot check)

fixes in this commit:

A) work around a possible bug in indexAfter()?:
   $pos.indexAfter() seems to return the same index as $pos.index() at some point
   -> fixed by increasing startIndex by 1 instead of using indexAfter()

B) endPos needs to be initialized with initial startPos + nodeSize and not
   with resulting startPos:
   -> moved initialization right after setting startPos
This commit is contained in:
Marius Tolzmann
2019-05-03 19:08:50 +02:00
parent d057d5d7d9
commit 9787b876fe
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/tiptap-utils/src/utils/getMarkRange.js
View File

@@ -17,13 +17,14 @@ export default function ($pos = null, type = null) {
let startIndex = $pos.index() let startIndex = $pos.index()
let startPos = $pos.start() + start.offset let startPos = $pos.start() + start.offset
let endIndex = startIndex + 1
let endPos = startPos + start.node.nodeSize
while (startIndex > 0 && link.isInSet($pos.parent.child(startIndex - 1).marks)) { while (startIndex > 0 && link.isInSet($pos.parent.child(startIndex - 1).marks)) {
startIndex -= 1 startIndex -= 1
startPos -= $pos.parent.child(startIndex).nodeSize startPos -= $pos.parent.child(startIndex).nodeSize
} }
let endIndex = $pos.indexAfter()
let endPos = startPos + start.node.nodeSize
while (endIndex < $pos.parent.childCount && link.isInSet($pos.parent.child(endIndex).marks)) { while (endIndex < $pos.parent.childCount && link.isInSet($pos.parent.child(endIndex).marks)) {
endPos += $pos.parent.child(endIndex).nodeSize endPos += $pos.parent.child(endIndex).nodeSize
endIndex += 1 endIndex += 1