From 8ed220a12de48b3c14e903b271d7f50aff6313f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= Date: Wed, 21 Apr 2021 23:38:13 +0200 Subject: [PATCH] fix: fix a bug for empty node selection where the bubble menu should not be visible, fix #1023 --- .../extension-bubble-menu/src/bubble-menu-plugin.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts index ff6783cf..a3bc0a67 100644 --- a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts +++ b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts @@ -88,9 +88,17 @@ export class BubbleMenuView { return } - const { from, to, empty } = selection + const { + from, + to, + empty, + $anchor, + } = selection - if (empty) { + // Sometime check for `empty` is not enough. + // Doubleclick an empty paragraph returns a node size of 2. + // So we check also for an empty text size. + if (empty || !$anchor.parent.textContent) { this.hide() return