From 9567519f8a1d5a34fa6b032dee8c8a51a32a5349 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Thu, 2 Apr 2020 09:14:05 +0200
Subject: [PATCH] fix bug in in node views, fix #652

---
 packages/tiptap-extensions/src/extensions/Placeholder.js | 6 ------
 packages/tiptap/src/Utils/ComponentView.js               | 1 +
 packages/tiptap/src/Utils/Extension.js                   | 4 ----
 packages/tiptap/src/Utils/ExtensionManager.js            | 2 +-
 4 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/packages/tiptap-extensions/src/extensions/Placeholder.js b/packages/tiptap-extensions/src/extensions/Placeholder.js
index 5214695b..1168e735 100644
--- a/packages/tiptap-extensions/src/extensions/Placeholder.js
+++ b/packages/tiptap-extensions/src/extensions/Placeholder.js
@@ -17,12 +17,6 @@ export default class Placeholder extends Extension {
     }
   }
 
-  get update() {
-    return view => {
-      view.updateState(view.state)
-    }
-  }
-
   get plugins() {
     return [
       new Plugin({
diff --git a/packages/tiptap/src/Utils/ComponentView.js b/packages/tiptap/src/Utils/ComponentView.js
index 26e6131f..e69bc034 100644
--- a/packages/tiptap/src/Utils/ComponentView.js
+++ b/packages/tiptap/src/Utils/ComponentView.js
@@ -44,6 +44,7 @@ export default class ComponentView {
     if (typeof this.extension.setSelection === 'function') {
       this.setSelection = this.extension.setSelection
     }
+
     if (typeof this.extension.update === 'function') {
       this.update = this.extension.update
     }
diff --git a/packages/tiptap/src/Utils/Extension.js b/packages/tiptap/src/Utils/Extension.js
index b28d281a..93a3d897 100644
--- a/packages/tiptap/src/Utils/Extension.js
+++ b/packages/tiptap/src/Utils/Extension.js
@@ -23,10 +23,6 @@ export default class Extension {
     return 'extension'
   }
 
-  get update() {
-    return () => {}
-  }
-
   get defaultOptions() {
     return {}
   }
diff --git a/packages/tiptap/src/Utils/ExtensionManager.js b/packages/tiptap/src/Utils/ExtensionManager.js
index 3d37f23f..1d5406cb 100644
--- a/packages/tiptap/src/Utils/ExtensionManager.js
+++ b/packages/tiptap/src/Utils/ExtensionManager.js
@@ -31,7 +31,7 @@ export default class ExtensionManager {
               Object.assign(obj, { [prop]: value })
 
               if (changed) {
-                extension.update(view)
+                view.updateState(view.state)
               }
 
               return true