From 9247fcb6cf20493d021664ddce95ad1c23c5a152 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= Date: Wed, 3 Nov 2021 21:09:40 +0100 Subject: [PATCH] fix: prevent adding hard breaks in isolated nodes --- packages/extension-hard-break/src/hard-break.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/extension-hard-break/src/hard-break.ts b/packages/extension-hard-break/src/hard-break.ts index 0d853b75..46a0afa7 100644 --- a/packages/extension-hard-break/src/hard-break.ts +++ b/packages/extension-hard-break/src/hard-break.ts @@ -57,10 +57,16 @@ export const HardBreak = Node.create({ return commands.first([ () => commands.exitCode(), () => commands.command(() => { + const { selection, storedMarks } = state + + if (selection.$from.parent.type.spec.isolating) { + return false + } + const { keepMarks } = this.options const { splittableMarks } = editor.extensionManager - const marks = state.storedMarks - || (state.selection.$to.parentOffset && state.selection.$from.marks()) + const marks = storedMarks + || (selection.$to.parentOffset && selection.$from.marks()) return chain() .insertContent({ type: this.name })