ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactoring

Browse Source
This commit is contained in:
Philipp Kühn
2021-09-07 20:55:40 +02:00
parent ca3763d3c2
commit 8b545e4ae1
2 changed files with 28 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/extension-bubble-menu/src/bubble-menu-plugin.ts
View File

@@ -113,14 +113,13 @@ export class BubbleMenuView {
} }
createTooltip() { createTooltip() {
if (this.tippy) { const { element: editorElement } = this.editor.options
const editorIsAttached = !!editorElement.parentElement
if (this.tippy || !editorIsAttached) {
return return
} }
const { element: editorElement } = this.editor.options
// Wait until editor element is attached to the document
if (editorElement.parentElement) {
this.tippy = tippy(editorElement, { this.tippy = tippy(editorElement, {
duration: 0, duration: 0,
getReferenceClientRect: null, getReferenceClientRect: null,
@@ -132,7 +131,6 @@ export class BubbleMenuView {
...this.tippyOptions, ...this.tippyOptions,
}) })
} }
}
update(view: EditorView, oldState?: EditorState) { update(view: EditorView, oldState?: EditorState) {
const { state, composing } = view const { state, composing } = view

10
packages/extension-floating-menu/src/floating-menu-plugin.ts
View File

@@ -99,14 +99,13 @@ export class FloatingMenuView {
} }
createTooltip() { createTooltip() {
if (this.tippy) { const { element: editorElement } = this.editor.options
const editorIsAttached = !!editorElement.parentElement
if (this.tippy || !editorIsAttached) {
return return
} }
const { element: editorElement } = this.editor.options
// Wait until editor element is attached to the document
if (editorElement.parentElement) {
this.tippy = tippy(editorElement, { this.tippy = tippy(editorElement, {
duration: 0, duration: 0,
getReferenceClientRect: null, getReferenceClientRect: null,
@@ -118,7 +117,6 @@ export class FloatingMenuView {
...this.tippyOptions, ...this.tippyOptions,
}) })
} }
}
update(view: EditorView, oldState?: EditorState) { update(view: EditorView, oldState?: EditorState) {
const { state, composing } = view const { state, composing } = view