From 39f942aca8d64618676b5a1922713d4da4e2542c Mon Sep 17 00:00:00 2001 From: Chrissi2812 Date: Wed, 15 May 2019 09:38:16 +0200 Subject: [PATCH 1/3] adding option to disable resizing of tables closes #310 --- packages/tiptap-extensions/src/nodes/Table.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/tiptap-extensions/src/nodes/Table.js b/packages/tiptap-extensions/src/nodes/Table.js index 8ddd3cbc..a209c61a 100644 --- a/packages/tiptap-extensions/src/nodes/Table.js +++ b/packages/tiptap-extensions/src/nodes/Table.js @@ -23,6 +23,12 @@ import TableNodes from './TableNodes' export default class Table extends Node { + get defaultOptions() { + return { + resizable: true, + } + } + get name() { return 'table' } @@ -74,7 +80,7 @@ export default class Table extends Node { get plugins() { return [ - columnResizing(), + ...(this.options.resizable ? [columnResizing()] : []), tableEditing(), ] } From 20bcffc94a929c2473fbecd5352ea8280eee46da Mon Sep 17 00:00:00 2001 From: Chrissi2812 Date: Wed, 15 May 2019 09:52:09 +0200 Subject: [PATCH 2/3] change order of methods to match other extensions --- packages/tiptap-extensions/src/nodes/Table.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/tiptap-extensions/src/nodes/Table.js b/packages/tiptap-extensions/src/nodes/Table.js index a209c61a..9289010d 100644 --- a/packages/tiptap-extensions/src/nodes/Table.js +++ b/packages/tiptap-extensions/src/nodes/Table.js @@ -23,16 +23,16 @@ import TableNodes from './TableNodes' export default class Table extends Node { + get name() { + return 'table' + } + get defaultOptions() { return { resizable: true, } } - get name() { - return 'table' - } - get schema() { return TableNodes.table } From 9a86801973a76a68ae6fc999ae634625118d7d82 Mon Sep 17 00:00:00 2001 From: Chrissi2812 Date: Wed, 15 May 2019 10:43:34 +0200 Subject: [PATCH 3/3] change table resizable default to false --- examples/Components/Routes/Tables/index.vue | 4 +++- packages/tiptap-extensions/src/nodes/Table.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/Components/Routes/Tables/index.vue b/examples/Components/Routes/Tables/index.vue index e9ad0754..9047fcb5 100644 --- a/examples/Components/Routes/Tables/index.vue +++ b/examples/Components/Routes/Tables/index.vue @@ -238,7 +238,9 @@ new Strike(), new Underline(), new History(), - new Table(), + new Table({ + resizable: true, + }), new TableHeader(), new TableCell(), new TableRow(), diff --git a/packages/tiptap-extensions/src/nodes/Table.js b/packages/tiptap-extensions/src/nodes/Table.js index 9289010d..90540757 100644 --- a/packages/tiptap-extensions/src/nodes/Table.js +++ b/packages/tiptap-extensions/src/nodes/Table.js @@ -29,7 +29,7 @@ export default class Table extends Node { get defaultOptions() { return { - resizable: true, + resizable: false, } }