From 70422dd107ed1ecdd8dfe41a8a93297124d2f1e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20K=C3=BChn?= Date: Mon, 7 Feb 2022 09:07:17 +0100 Subject: [PATCH] fix: fix RangeError bug when selecting all text, fix #2490 --- demos/src/Examples/Tables/Vue/index.vue | 2 +- packages/core/src/commands/setTextSelection.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/demos/src/Examples/Tables/Vue/index.vue b/demos/src/Examples/Tables/Vue/index.vue index 8e20311e..d07857e4 100644 --- a/demos/src/Examples/Tables/Vue/index.vue +++ b/demos/src/Examples/Tables/Vue/index.vue @@ -145,7 +145,7 @@ export default { Hans Pagel wrote this - that’s it + diff --git a/packages/core/src/commands/setTextSelection.ts b/packages/core/src/commands/setTextSelection.ts index d1ac9391..75b0e02c 100644 --- a/packages/core/src/commands/setTextSelection.ts +++ b/packages/core/src/commands/setTextSelection.ts @@ -19,8 +19,8 @@ export const setTextSelection: RawCommands['setTextSelection'] = position => ({ const { from, to } = typeof position === 'number' ? { from: position, to: position } : position - const minPos = 0 - const maxPos = tr.doc.content.size + const minPos = TextSelection.atStart(doc).from + const maxPos = doc.content.size const resolvedFrom = minMax(from, minPos, maxPos) const resolvedEnd = minMax(to, minPos, maxPos) const selection = TextSelection.create(doc, resolvedFrom, resolvedEnd)