From 63902d4bdbecc68aacfb0842fb5d5bc0043d92b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= Date: Wed, 5 May 2021 13:49:32 +0200 Subject: [PATCH] remove replaceRange from mention node --- packages/core/src/commands/insertContentAt.ts | 4 ++-- packages/extension-mention/src/mention.ts | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/core/src/commands/insertContentAt.ts b/packages/core/src/commands/insertContentAt.ts index 14b2ab26..659761e6 100644 --- a/packages/core/src/commands/insertContentAt.ts +++ b/packages/core/src/commands/insertContentAt.ts @@ -26,8 +26,8 @@ export const insertContentAt: RawCommands['insertContentAt'] = (range, value) => return true } - if (!tr.selection.empty) { - tr.deleteRange(range.from, range.to) + if (range.from !== range.to) { + tr.delete(range.from, range.to) } tr.insert(range.from, content) diff --git a/packages/extension-mention/src/mention.ts b/packages/extension-mention/src/mention.ts index 3c2c013b..8e4ed9ca 100644 --- a/packages/extension-mention/src/mention.ts +++ b/packages/extension-mention/src/mention.ts @@ -17,12 +17,15 @@ export const Mention = Node.create({ editor .chain() .focus() - .replaceRange(range, 'mention', props) + .insertContentAt(range, { + type: 'mention', + attrs: props, + }) .insertContent(' ') .run() }, allow: ({ editor, range }) => { - return editor.can().replaceRange(range, 'mention') + return editor.can().insertContentAt(range, { type: 'mention' }) }, }, },