ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: hide bubble menu on drag, fix #1443

Browse Source
This commit is contained in:
Philipp Kühn
2021-06-14 18:28:27 +02:00
parent 6aa424b422
commit 6034eb9b30
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/extension-bubble-menu/src/bubble-menu-plugin.ts
View File

@@ -34,6 +34,7 @@ export class BubbleMenuView {
this.element = element this.element = element
this.view = view this.view = view
this.element.addEventListener('mousedown', this.mousedownHandler, { capture: true }) this.element.addEventListener('mousedown', this.mousedownHandler, { capture: true })
this.view.dom.addEventListener('dragstart', this.dragstartHandler)
this.editor.on('focus', this.focusHandler) this.editor.on('focus', this.focusHandler)
this.editor.on('blur', this.blurHandler) this.editor.on('blur', this.blurHandler)
this.createTooltip(tippyOptions) this.createTooltip(tippyOptions)
@@ -44,6 +45,10 @@ export class BubbleMenuView {
this.preventHide = true this.preventHide = true
} }
dragstartHandler = () => {
this.hide()
}
focusHandler = () => { focusHandler = () => {
// we use `setTimeout` to make sure `selection` is already updated // we use `setTimeout` to make sure `selection` is already updated
setTimeout(() => this.update(this.editor.view)) setTimeout(() => this.update(this.editor.view))
@@ -131,6 +136,7 @@ export class BubbleMenuView {
destroy() { destroy() {
this.tippy.destroy() this.tippy.destroy()
this.element.removeEventListener('mousedown', this.mousedownHandler) this.element.removeEventListener('mousedown', this.mousedownHandler)
this.view.dom.removeEventListener('dragstart', this.dragstartHandler)
this.editor.off('focus', this.focusHandler) this.editor.off('focus', this.focusHandler)
this.editor.off('blur', this.blurHandler) this.editor.off('blur', this.blurHandler)
} }