From 5f740da53e9f9da1bea841427f0bb470e0affbc9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= Date: Fri, 28 Sep 2018 13:52:57 +0200 Subject: [PATCH] remove type from mentions --- examples/Components/Routes/Mentions/index.vue | 3 +-- packages/tiptap-extensions/src/nodes/Mention.js | 7 ++----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/examples/Components/Routes/Mentions/index.vue b/examples/Components/Routes/Mentions/index.vue index 15e71551..50c12868 100644 --- a/examples/Components/Routes/Mentions/index.vue +++ b/examples/Components/Routes/Mentions/index.vue @@ -7,7 +7,7 @@ Mentions

- Yeah Philipp Kühn and Hans Pagel. + Yeah Philipp Kühn and Hans Pagel.

@@ -138,7 +138,6 @@ export default { this.insertMention({ pos: this.pos, attrs: { - type: 'user', id: user.id, label: user.name, }, diff --git a/packages/tiptap-extensions/src/nodes/Mention.js b/packages/tiptap-extensions/src/nodes/Mention.js index de3e6842..7a2de3d8 100644 --- a/packages/tiptap-extensions/src/nodes/Mention.js +++ b/packages/tiptap-extensions/src/nodes/Mention.js @@ -11,7 +11,6 @@ export default class MentionNode extends Node { get schema() { return { attrs: { - type: {}, id: {}, label: {}, }, @@ -23,19 +22,17 @@ export default class MentionNode extends Node { 'span', { class: 'mention', - 'data-mention-type': node.attrs.type, 'data-mention-id': node.attrs.id, }, `@${node.attrs.label}`, ], parseDOM: [ { - tag: 'span[data-mention-type][data-mention-id]', + tag: 'span[data-mention-id]', getAttrs: dom => { - const type = dom.getAttribute('data-mention-type') const id = dom.getAttribute('data-mention-id') const label = dom.innerText.split('@').join('') - return { type, id, label } + return { id, label } }, }, ],