From 5e53e444d5552dc89751b08ed0887e3b89791865 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= Date: Thu, 22 Apr 2021 23:10:54 +0200 Subject: [PATCH] refactor: use chain on checkbox click --- packages/extension-task-item/src/task-item.ts | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/packages/extension-task-item/src/task-item.ts b/packages/extension-task-item/src/task-item.ts index 41eaf5a6..a86216e7 100644 --- a/packages/extension-task-item/src/task-item.ts +++ b/packages/extension-task-item/src/task-item.ts @@ -77,7 +77,6 @@ export const TaskItem = Node.create({ getPos, editor, }) => { - const { view } = editor const listItem = document.createElement('li') const checkboxWrapper = document.createElement('label') const checkboxStyler = document.createElement('span') @@ -90,10 +89,17 @@ export const TaskItem = Node.create({ const { checked } = event.target as any if (typeof getPos === 'function') { - view.dispatch(view.state.tr.setNodeMarkup(getPos(), undefined, { - checked, - })) - editor.commands.focus() + editor + .chain() + .focus() + .command(({ tr }) => { + tr.setNodeMarkup(getPos(), undefined, { + checked, + }) + + return true + }) + .run() } })