From 2489997e919283c937b04f376461241a82a8a387 Mon Sep 17 00:00:00 2001
From: Chrissi2812 <cf@pixel-kraft.de>
Date: Thu, 6 Sep 2018 11:19:10 +0200
Subject: [PATCH 1/2] UnderlineMark added

---
 examples/Components/Routes/Basic/index.vue    | 10 +++++
 examples/assets/images/icons/underline.svg    |  1 +
 packages/tiptap-extensions/src/index.js       |  1 +
 packages/tiptap-extensions/src/marks/Bold.js  |  2 +-
 .../tiptap-extensions/src/marks/Underline.js  | 41 +++++++++++++++++++
 5 files changed, 54 insertions(+), 1 deletion(-)
 create mode 100644 examples/assets/images/icons/underline.svg
 create mode 100644 packages/tiptap-extensions/src/marks/Underline.js

diff --git a/examples/Components/Routes/Basic/index.vue b/examples/Components/Routes/Basic/index.vue
index b833eda0..d31d33d6 100644
--- a/examples/Components/Routes/Basic/index.vue
+++ b/examples/Components/Routes/Basic/index.vue
@@ -29,6 +29,14 @@
 						<icon name="strike" />
 					</button>
 
+					<button
+						class="menubar__button"
+						:class="{ 'is-active': marks.underline.active() }"
+						@click="marks.underline.command"
+					>
+						<icon name="underline" />
+					</button>
+
 					<button
 						class="menubar__button"
 						@click="marks.code.command"
@@ -141,6 +149,7 @@ import {
 	ItalicMark,
 	LinkMark,
 	StrikeMark,
+	UnderlineMark,
 	HistoryExtension,
 } from 'tiptap-extensions'
 
@@ -166,6 +175,7 @@ export default {
 				new ItalicMark(),
 				new LinkMark(),
 				new StrikeMark(),
+				new UnderlineMark(),
 				new HistoryExtension(),
 			],
 		}
diff --git a/examples/assets/images/icons/underline.svg b/examples/assets/images/icons/underline.svg
new file mode 100644
index 00000000..eb4e6963
--- /dev/null
+++ b/examples/assets/images/icons/underline.svg
@@ -0,0 +1 @@
+<svg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg" stroke-linejoin="round" stroke-miterlimit="1.414"><path fill="none" d="M0 0h24v24H0z"/><clipPath id="a"><path d="M0 0h24v24H0z"/></clipPath><g clip-path="url(#a)"><path d="M12.556 18.667c4.413 0 8-3.587 8-8V1.666A1.667 1.667 0 0 0 18.89 0h-.002a1.669 1.669 0 0 0-1.666 1.666v9.001a4.671 4.671 0 0 1-4.666 4.666 4.671 4.671 0 0 1-4.667-4.666V1.666A1.667 1.667 0 0 0 6.223 0h-.001a1.667 1.667 0 0 0-1.666 1.666v9.001c0 4.413 3.586 8 8 8zm-8.002 2.666c-.353 0-.692.141-.942.39-.249.25-.39.589-.39.942v.003A1.332 1.332 0 0 0 4.554 24h16.003a1.332 1.332 0 0 0 1.332-1.332v-.003a1.332 1.332 0 0 0-1.332-1.332H4.554z" fill-rule="nonzero"/></g></svg>
diff --git a/packages/tiptap-extensions/src/index.js b/packages/tiptap-extensions/src/index.js
index d40b75ed..84165240 100644
--- a/packages/tiptap-extensions/src/index.js
+++ b/packages/tiptap-extensions/src/index.js
@@ -15,6 +15,7 @@ export { default as CodeMark } from './marks/Code'
 export { default as ItalicMark } from './marks/Italic'
 export { default as LinkMark } from './marks/Link'
 export { default as StrikeMark } from './marks/Strike'
+export { default as UnderlineMark } from './marks/Underline'
 
 export { default as HistoryExtension } from './extensions/History'
 export { default as PlaceholderExtension } from './extensions/Placeholder'
diff --git a/packages/tiptap-extensions/src/marks/Bold.js b/packages/tiptap-extensions/src/marks/Bold.js
index a6dba903..b982725a 100644
--- a/packages/tiptap-extensions/src/marks/Bold.js
+++ b/packages/tiptap-extensions/src/marks/Bold.js
@@ -38,7 +38,7 @@ export default class BoldMark extends Mark {
 
 	inputRules({ type }) {
 		return [
-			markInputRule(/(?:\*\*|__)([^\*_]+)(?:\*\*|__)$/, type),
+			markInputRule(/\*\*([^*]+)\*\*$/, type),
 		]
 	}
 
diff --git a/packages/tiptap-extensions/src/marks/Underline.js b/packages/tiptap-extensions/src/marks/Underline.js
new file mode 100644
index 00000000..b0878dd9
--- /dev/null
+++ b/packages/tiptap-extensions/src/marks/Underline.js
@@ -0,0 +1,41 @@
+import { Mark } from 'tiptap'
+import { toggleMark, markInputRule } from 'tiptap-commands'
+
+export default class UnderlineMark extends Mark {
+
+	get name() {
+		return 'underline'
+	}
+
+	get schema() {
+		return {
+			parseDOM: [
+				{
+					tag: 'u',
+				},
+				{
+					style: 'text-decoration',
+					getAttrs: value => value === 'underline',
+				},
+			],
+			toDOM: () => ['u', 0],
+		}
+	}
+
+	keys({ type }) {
+		return {
+			'Mod-u': toggleMark(type),
+		}
+	}
+
+	command({ type }) {
+		return toggleMark(type)
+	}
+
+	inputRules({ type }) {
+		return [
+			markInputRule(/__([^_]+)__$/, type),
+		]
+	}
+
+}

From 2b17cabf8f4deb6f1eeca3a11f979c5cafa62198 Mon Sep 17 00:00:00 2001
From: Chrissi2812 <cf@pixel-kraft.de>
Date: Tue, 11 Sep 2018 10:18:31 +0200
Subject: [PATCH 2/2] removed Markdown support for UnderlineMark

---
 packages/tiptap-extensions/src/marks/Bold.js      | 2 +-
 packages/tiptap-extensions/src/marks/Underline.js | 8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/packages/tiptap-extensions/src/marks/Bold.js b/packages/tiptap-extensions/src/marks/Bold.js
index b982725a..a6dba903 100644
--- a/packages/tiptap-extensions/src/marks/Bold.js
+++ b/packages/tiptap-extensions/src/marks/Bold.js
@@ -38,7 +38,7 @@ export default class BoldMark extends Mark {
 
 	inputRules({ type }) {
 		return [
-			markInputRule(/\*\*([^*]+)\*\*$/, type),
+			markInputRule(/(?:\*\*|__)([^\*_]+)(?:\*\*|__)$/, type),
 		]
 	}
 
diff --git a/packages/tiptap-extensions/src/marks/Underline.js b/packages/tiptap-extensions/src/marks/Underline.js
index b0878dd9..f8a25c6f 100644
--- a/packages/tiptap-extensions/src/marks/Underline.js
+++ b/packages/tiptap-extensions/src/marks/Underline.js
@@ -1,5 +1,5 @@
 import { Mark } from 'tiptap'
-import { toggleMark, markInputRule } from 'tiptap-commands'
+import { toggleMark } from 'tiptap-commands'
 
 export default class UnderlineMark extends Mark {
 
@@ -32,10 +32,4 @@ export default class UnderlineMark extends Mark {
 		return toggleMark(type)
 	}
 
-	inputRules({ type }) {
-		return [
-			markInputRule(/__([^_]+)__$/, type),
-		]
-	}
-
 }