ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #206 from Chrissi2812/fix-link-example

Browse Source 
Fix link example
This commit is contained in:
Philipp Kühn
2019-03-06 06:47:21 +01:00
committed by GitHub
parent 3de6b13004 04de7048f2
commit 575b082c4e
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
examples/Components/Routes/Links/index.vue
View File

@@ -1,6 +1,6 @@
<template> <template>
<div class="editor"> <div class="editor">
<editor-menu-bubble class="menububble" :editor="editor"> <editor-menu-bubble class="menububble" :editor="editor" @hide="hideLinkMenu">
<div <div
slot-scope="{ commands, isActive, getMarkAttrs, menu }" slot-scope="{ commands, isActive, getMarkAttrs, menu }"
class="menububble" class="menububble"
@@ -21,7 +21,7 @@
@click="showLinkMenu(getMarkAttrs('link'))" @click="showLinkMenu(getMarkAttrs('link'))"
:class="{ 'is-active': isActive.link() }" :class="{ 'is-active': isActive.link() }"
> >
<span>Add Link</span> <span>{{ isActive.link() ? 'Update Link' : 'Add Link'}}</span>
<icon name="link" /> <icon name="link" />
</button> </button>
</template> </template>

6
packages/tiptap/src/Components/EditorMenuBubble.js
View File

@@ -28,6 +28,12 @@ export default {
editor.registerPlugin(MenuBubble({ editor.registerPlugin(MenuBubble({
element: this.$el, element: this.$el,
onUpdate: menu => { onUpdate: menu => {
// the second check ensures event is fired only once
if (menu.isActive && this.menu.isActive === false) {
this.$emit('show', menu)
} else if (!menu.isActive && this.menu.isActive === true) {
this.$emit('hide', menu)
}
this.menu = menu this.menu = menu
}, },
})) }))