Merge pull request #1452 from YousefED/patch-2

use forwardRef for react wrappers
This commit is contained in:
Philipp Kühn
2021-06-14 16:02:45 +02:00
committed by GitHub
2 changed files with 33 additions and 28 deletions

View File

@@ -5,17 +5,20 @@ export interface NodeViewContentProps {
as?: React.ElementType, as?: React.ElementType,
} }
export const NodeViewContent: React.FC<NodeViewContentProps> = props => { export const NodeViewContent: React.FC<NodeViewContentProps> =
const Tag = props.as || 'div' React.forwardRef((props, ref) => {
const Tag = props.as || 'div'
return ( return (
<Tag <Tag
{...props} {...props}
data-node-view-content="" ref={ref}
style={{ data-node-view-content=""
...props.style, style={{
whiteSpace: 'pre-wrap', ...props.style,
}} whiteSpace: 'pre-wrap',
/> }}
) />
} )
})

View File

@@ -6,19 +6,21 @@ export interface NodeViewWrapperProps {
as?: React.ElementType, as?: React.ElementType,
} }
export const NodeViewWrapper: React.FC<NodeViewWrapperProps> = props => { export const NodeViewWrapper: React.FC<NodeViewWrapperProps> =
const { onDragStart } = useReactNodeView() React.forwardRef((props, ref) => {
const Tag = props.as || 'div' const { onDragStart } = useReactNodeView()
const Tag = props.as || 'div'
return ( return (
<Tag <Tag
{...props} {...props}
data-node-view-wrapper="" ref={ref}
onDragStart={onDragStart} data-node-view-wrapper=""
style={{ onDragStart={onDragStart}
...props.style, style={{
whiteSpace: 'normal', ...props.style,
}} whiteSpace: 'normal',
/> }}
) />
} )
})