ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: #1898 Made the EventEmitter generic to improve the types of the tiptap events (#1959)

Browse Source
This commit is contained in:
HuiiBuh
2021-09-30 09:25:40 +02:00
committed by GitHub
parent 14f62dddb3
commit 54e85fd284
4 changed files with 34 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/core/src/EventEmitter.ts
View File

@@ -1,8 +1,12 @@
export default class EventEmitter {
type StringKeyOf<T> = Extract<keyof T, string>;
type CallbackType<T extends Record<string, any>, EVENT extends StringKeyOf<T>> = T[EVENT] extends any[] ? T[EVENT] : [T[EVENT]];
type CallbackFunction<T extends Record<string, any>, EVENT extends StringKeyOf<T>> = (...props: CallbackType<T, EVENT>) => any
export default class EventEmitter<T extends Record<string, any>> {
private callbacks: { [key: string]: Function[] } = {}
public on(event: string, fn: Function): this {
public on<EVENT extends StringKeyOf<T>>(event: EVENT, fn: CallbackFunction<T, EVENT>): this {
if (!this.callbacks[event]) {
this.callbacks[event] = []
}
@@ -12,7 +16,7 @@ export default class EventEmitter {
return this
}
protected emit(event: string, ...args: any): this {
protected emit<EVENT extends StringKeyOf<T>>(event: EVENT, ...args: CallbackType<T, EVENT>): this {
const callbacks = this.callbacks[event]
if (callbacks) {
@@ -22,7 +26,7 @@ export default class EventEmitter {
return this
}
public off(event: string, fn?: Function): this {
public off<EVENT extends StringKeyOf<T>>(event: EVENT, fn?: CallbackFunction<T, EVENT>): this {
const callbacks = this.callbacks[event]
if (callbacks) {