From f47bc4693e9471211d408a72b1ee67e5d285c9ad Mon Sep 17 00:00:00 2001 From: Hans Pagel Date: Tue, 3 Nov 2020 17:08:04 +0100 Subject: [PATCH 1/7] clean up --- docs/src/docPages/api/extensions/focus.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/src/docPages/api/extensions/focus.md b/docs/src/docPages/api/extensions/focus.md index 6eacca5e..2d011777 100644 --- a/docs/src/docPages/api/extensions/focus.md +++ b/docs/src/docPages/api/extensions/focus.md @@ -15,12 +15,6 @@ yarn add @tiptap/extension-focus | className | string | has-focus | The class that is applied to the focused element. | | nested | boolean | true | When enabled nested elements get the focus class, too. | -## Commands -*None* - -## Keyboard shortcuts -*None* - ## Source code [packages/extension-focus/](https://github.com/ueberdosis/tiptap-next/blob/main/packages/extension-focus/) From 646c8697d65841301a729c32b6436366da1b2393 Mon Sep 17 00:00:00 2001 From: Hans Pagel Date: Tue, 3 Nov 2020 17:10:17 +0100 Subject: [PATCH 2/7] add node views heading to the documentation --- docs/src/docPages/guide/build-custom-extensions.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/src/docPages/guide/build-custom-extensions.md b/docs/src/docPages/guide/build-custom-extensions.md index f4dd16f3..195d4b8d 100644 --- a/docs/src/docPages/guide/build-custom-extensions.md +++ b/docs/src/docPages/guide/build-custom-extensions.md @@ -289,6 +289,8 @@ const CustomUnderline = Underline.extend({ }) ``` +### Node views + ## Option 2: Start from scratch ### Read the documentation From a0885e494be0d32a8aed9f8f016f066a862acd3a Mon Sep 17 00:00:00 2001 From: Hans Pagel Date: Thu, 5 Nov 2020 09:38:39 +0100 Subject: [PATCH 3/7] update Slack channel --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e827dd9d..a551cb83 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -54,7 +54,7 @@ jobs: with: status: ${{ job.status }} steps: ${{ toJson(steps) }} - channel: '#tiptap-next' + channel: '#tiptap-notifications' if: failure() test: @@ -107,7 +107,7 @@ jobs: with: status: ${{ job.status }} steps: ${{ toJson(steps) }} - channel: '#tiptap-next' + channel: '#tiptap-notifications' if: failure() build: @@ -154,5 +154,5 @@ jobs: with: status: ${{ job.status }} steps: ${{ toJson(steps) }} - channel: '#tiptap-next' + channel: '#tiptap-notifications' if: failure() From 5110f73e66abb46c25156d335a091f361842a5fa Mon Sep 17 00:00:00 2001 From: Hans Pagel Date: Thu, 5 Nov 2020 11:45:36 +0100 Subject: [PATCH 4/7] disable build step for now --- .github/workflows/main.yml | 72 +++++++++++++++++++------------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a551cb83..6ffb9036 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -110,49 +110,49 @@ jobs: channel: '#tiptap-notifications' if: failure() - build: - runs-on: ubuntu-latest + # build: + # runs-on: ubuntu-latest - needs: lint + # needs: lint - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + # env: + # SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - strategy: - matrix: - node-version: [14] + # strategy: + # matrix: + # node-version: [14] - steps: + # steps: - - uses: actions/checkout@v2.3.3 + # - uses: actions/checkout@v2.3.3 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v2.1.2 - with: - node-version: ${{ matrix.node-version }} + # - name: Use Node.js ${{ matrix.node-version }} + # uses: actions/setup-node@v2.1.2 + # with: + # node-version: ${{ matrix.node-version }} - - name: Load cached dependencies - uses: actions/cache@v2 - id: cache - with: - path: | - **/node_modules - /home/runner/.cache/Cypress - key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/yarn.lock') }} + # - name: Load cached dependencies + # uses: actions/cache@v2 + # id: cache + # with: + # path: | + # **/node_modules + # /home/runner/.cache/Cypress + # key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/yarn.lock') }} - - name: Install dependencies - id: install-dependencies - if: steps.cache.outputs.cache-hit != 'true' - run: yarn install + # - name: Install dependencies + # id: install-dependencies + # if: steps.cache.outputs.cache-hit != 'true' + # run: yarn install - - name: Build packages dependencies - id: build-packages - run: yarn build:packages + # - name: Build packages dependencies + # id: build-packages + # run: yarn build:packages - - name: Send Slack notifications - uses: act10ns/slack@v1 - with: - status: ${{ job.status }} - steps: ${{ toJson(steps) }} - channel: '#tiptap-notifications' - if: failure() + # - name: Send Slack notifications + # uses: act10ns/slack@v1 + # with: + # status: ${{ job.status }} + # steps: ${{ toJson(steps) }} + # channel: '#tiptap-notifications' + # if: failure() From 729fa7f0360fd4eabaf878bbb7b575967ef6a07b Mon Sep 17 00:00:00 2001 From: Hans Pagel Date: Thu, 5 Nov 2020 11:46:27 +0100 Subject: [PATCH 5/7] add content to the gapcursor page --- .../demos/Extensions/Gapcursor/index.spec.js | 5 ++ docs/src/demos/Extensions/Gapcursor/index.vue | 77 +++++++++++++++++++ docs/src/docPages/api/extensions/gapcursor.md | 12 +-- 3 files changed, 85 insertions(+), 9 deletions(-) create mode 100644 docs/src/demos/Extensions/Gapcursor/index.spec.js create mode 100644 docs/src/demos/Extensions/Gapcursor/index.vue diff --git a/docs/src/demos/Extensions/Gapcursor/index.spec.js b/docs/src/demos/Extensions/Gapcursor/index.spec.js new file mode 100644 index 00000000..3adf87fd --- /dev/null +++ b/docs/src/demos/Extensions/Gapcursor/index.spec.js @@ -0,0 +1,5 @@ +context('/examples/gapcursor', () => { + before(() => { + cy.visit('/examples/gapcursor') + }) +}) diff --git a/docs/src/demos/Extensions/Gapcursor/index.vue b/docs/src/demos/Extensions/Gapcursor/index.vue new file mode 100644 index 00000000..14e46c2a --- /dev/null +++ b/docs/src/demos/Extensions/Gapcursor/index.vue @@ -0,0 +1,77 @@ + + + + + diff --git a/docs/src/docPages/api/extensions/gapcursor.md b/docs/src/docPages/api/extensions/gapcursor.md index 1f16726b..52d358f2 100644 --- a/docs/src/docPages/api/extensions/gapcursor.md +++ b/docs/src/docPages/api/extensions/gapcursor.md @@ -1,4 +1,7 @@ # Gapcursor +This extension loads the [ProseMirror Gapcursor plugin](https://github.com/ProseMirror/prosemirror-gapcursor) by Marijn Haverbeke, which adds a gap for the cursor in places that don’t allow regular selection. For example, after a table at the end of a document. + +Note that tiptap is renderless, but the dropcursor needs CSS for its appearance. The default CSS is added to the usage example below. ## Installation ```bash @@ -9,15 +12,6 @@ npm install @tiptap/extension-gapcursor yarn add @tiptap/extension-gapcursor ``` -## Settings -*None* - -## Commands -*None* - -## Keyboard shortcuts -*None* - ## Source code [packages/extension-gapcursor/](https://github.com/ueberdosis/tiptap-next/blob/main/packages/extension-gapcursor/) From 81471723252b295b9ba4189c5690e4964d6a4486 Mon Sep 17 00:00:00 2001 From: Hans Pagel Date: Thu, 5 Nov 2020 13:51:09 +0100 Subject: [PATCH 6/7] update the gapcursor page & example --- docs/src/demos/Extensions/Gapcursor/index.vue | 7 ++++--- docs/src/docPages/api/extensions/gapcursor.md | 2 +- docs/src/links.yaml | 1 - 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/src/demos/Extensions/Gapcursor/index.vue b/docs/src/demos/Extensions/Gapcursor/index.vue index 14e46c2a..11d5bc99 100644 --- a/docs/src/demos/Extensions/Gapcursor/index.vue +++ b/docs/src/demos/Extensions/Gapcursor/index.vue @@ -9,7 +9,7 @@ import { Editor, EditorContent } from '@tiptap/vue-starter-kit' import Document from '@tiptap/extension-document' import Paragraph from '@tiptap/extension-paragraph' import Text from '@tiptap/extension-text' -import Gapcursor from '@tiptap/extension-focus' +import Gapcursor from '@tiptap/extension-gapcursor' import Image from '@tiptap/extension-image' export default { @@ -33,7 +33,7 @@ export default { Gapcursor(), ], content: ` -

Try to set the cursor behind the image!

+

Try to set the cursor behind the image with your arrow keys! You should see big blinking cursor right from the image. This is the gapcursor.

`, }) @@ -46,13 +46,14 @@ export default {