From 6c1e705a7aa0e41d634a52c2a27133b0ab402710 Mon Sep 17 00:00:00 2001 From: BrianHung Date: Fri, 9 Jul 2021 12:01:29 -0700 Subject: [PATCH 1/2] update task-item.ts nodeview to update data-checked #1156 --- packages/extension-task-item/src/task-item.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/extension-task-item/src/task-item.ts b/packages/extension-task-item/src/task-item.ts index 5299b70f..6f3d2f88 100644 --- a/packages/extension-task-item/src/task-item.ts +++ b/packages/extension-task-item/src/task-item.ts @@ -132,6 +132,7 @@ export const TaskItem = Node.create({ return false } + listItem.dataset.checked = updatedNode.attrs.checked if (updatedNode.attrs.checked) { checkbox.setAttribute('checked', 'checked') } else { From 1ac8353768432ed746e8934b100cefe028dc7fff Mon Sep 17 00:00:00 2001 From: BrianHung Date: Sat, 10 Jul 2021 12:27:40 -0700 Subject: [PATCH 2/2] initialize task-item nodeview with dataset checked --- packages/extension-task-item/src/task-item.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/extension-task-item/src/task-item.ts b/packages/extension-task-item/src/task-item.ts index 6f3d2f88..3183e043 100644 --- a/packages/extension-task-item/src/task-item.ts +++ b/packages/extension-task-item/src/task-item.ts @@ -111,6 +111,7 @@ export const TaskItem = Node.create({ } }) + listItem.dataset.checked = node.attrs.checked if (node.attrs.checked) { checkbox.setAttribute('checked', 'checked') }