From 3e7bd37d63e673ecaf562ddfdc2884f10fa22622 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Tue, 8 Sep 2020 00:15:41 +0200
Subject: [PATCH] add dynamic callback type

---
 packages/core/src/test.ts | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/packages/core/src/test.ts b/packages/core/src/test.ts
index c97cabe4..ed244a06 100644
--- a/packages/core/src/test.ts
+++ b/packages/core/src/test.ts
@@ -1,4 +1,4 @@
-import { NodeSpec } from "prosemirror-model";
+import { NodeSpec, NodeType } from "prosemirror-model";
 import deepmerge from 'deepmerge'
 import collect from 'collect.js'
 import { Editor, CommandSpec } from '@tiptap/core'
@@ -780,14 +780,14 @@ let three = copyProperties(one, two)
 type NoInfer<T> = [T][T extends any ? 0 : never];
 
 interface ExtensionCallback {
-  editor: Editor
   name: string
+  editor: Editor
 }
 
-type ExtensionExtends = {
+interface ExtensionExtends<Callback = ExtensionCallback> {
   name: string
   options: AnyObject
-  commands: (params: ExtensionCallback) => CommandSpec
+  commands: (params: Callback) => CommandSpec
 }
 
 class ExtensionTest<Options, Extends extends ExtensionExtends = ExtensionExtends> {
@@ -842,9 +842,14 @@ class ExtensionTest<Options, Extends extends ExtensionExtends = ExtensionExtends
   }
 }
 
-interface NodeExtends extends ExtensionExtends {
+interface NodeCallback extends ExtensionCallback {
+  // TODO: fix optional
+  type?: NodeType
+}
+
+interface NodeExtends<Callback = NodeCallback> extends ExtensionExtends<Callback> {
   topNode: boolean
-  schema: (params: ExtensionCallback) => NodeSpec
+  schema: (params: Callback) => NodeSpec
 }
 
 class NodeTest<Options> extends ExtensionTest<Options, NodeExtends> {