From 5ae9d8cca45fec94f22fa47e5a2f35637ba32164 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Tue, 1 Dec 2020 14:55:11 +0100
Subject: [PATCH 1/7] fix history for collab demo

---
 docs/src/demos/Examples/CollaborativeEditing/index.vue | 2 +-
 packages/extension-collaboration/src/index.ts          | 6 +++---
 packages/extension-history/src/index.ts                | 2 ++
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/docs/src/demos/Examples/CollaborativeEditing/index.vue b/docs/src/demos/Examples/CollaborativeEditing/index.vue
index 3c7f1248..30b0e41a 100644
--- a/docs/src/demos/Examples/CollaborativeEditing/index.vue
+++ b/docs/src/demos/Examples/CollaborativeEditing/index.vue
@@ -82,7 +82,7 @@ export default {
 
     this.editor = new Editor({
       extensions: [
-        ...defaultExtensions(),
+        ...defaultExtensions().filter(extension => extension.config.name !== 'history'),
         Collaboration.configure({
           provider,
         }),
diff --git a/packages/extension-collaboration/src/index.ts b/packages/extension-collaboration/src/index.ts
index 976d1adb..6249c4bb 100644
--- a/packages/extension-collaboration/src/index.ts
+++ b/packages/extension-collaboration/src/index.ts
@@ -26,9 +26,9 @@ const Collaboration = Extension.create({
 
   addKeyboardShortcuts() {
     return {
-      'Mod-z': undo,
-      'Mod-y': redo,
-      'Mod-Shift-z': redo,
+      'Mod-z': () => undo(this.editor.state),
+      'Mod-y': () => redo(this.editor.state),
+      'Mod-Shift-z': () => redo(this.editor.state),
     }
   },
 
diff --git a/packages/extension-history/src/index.ts b/packages/extension-history/src/index.ts
index 6f389f2e..b5d48acf 100644
--- a/packages/extension-history/src/index.ts
+++ b/packages/extension-history/src/index.ts
@@ -7,6 +7,8 @@ export interface HistoryOptions {
 }
 
 const History = Extension.create({
+  name: 'history',
+
   defaultOptions: <HistoryOptions>{
     depth: 100,
     newGroupDelay: 500,

From 30d5ab5f39a0bce78bda10721060442f0e272235 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Tue, 1 Dec 2020 21:58:29 +0100
Subject: [PATCH 2/7] dont add focus and blur transactions to history

---
 packages/core/src/extensions/focusEvents.ts | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/core/src/extensions/focusEvents.ts b/packages/core/src/extensions/focusEvents.ts
index 051571f4..fad279e6 100644
--- a/packages/core/src/extensions/focusEvents.ts
+++ b/packages/core/src/extensions/focusEvents.ts
@@ -16,7 +16,10 @@ export const FocusEvents = Extension.create({
             focus: (view, event) => {
               editor.isFocused = true
 
-              const transaction = editor.state.tr.setMeta('focus', { event })
+              const transaction = editor.state.tr
+                .setMeta('focus', { event })
+                .setMeta('addToHistory', false)
+
               view.dispatch(transaction)
 
               return true
@@ -24,7 +27,10 @@ export const FocusEvents = Extension.create({
             blur: (view, event) => {
               editor.isFocused = false
 
-              const transaction = editor.state.tr.setMeta('blur', { event })
+              const transaction = editor.state.tr
+                .setMeta('blur', { event })
+                .setMeta('addToHistory', false)
+
               view.dispatch(transaction)
 
               return true

From 532eaa4e869180d639a696f2feb26c7ca6d334d5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Tue, 1 Dec 2020 23:32:39 +0100
Subject: [PATCH 3/7] fix chain again

---
 packages/core/src/CommandManager.ts | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/packages/core/src/CommandManager.ts b/packages/core/src/CommandManager.ts
index b5ea87cd..c41dcb1f 100644
--- a/packages/core/src/CommandManager.ts
+++ b/packages/core/src/CommandManager.ts
@@ -68,7 +68,6 @@ export default class CommandManager {
     const callbacks: boolean[] = []
     const hasStartTransaction = !!startTr
     const tr = startTr || state.tr
-    const props = this.buildProps(tr, shouldDispatch)
 
     return new Proxy({}, {
       get: (_, name: string, proxy) => {
@@ -87,7 +86,9 @@ export default class CommandManager {
         }
 
         return (...args: any) => {
+          const props = this.buildProps(tr, shouldDispatch)
           const callback = command(...args)(props)
+
           callbacks.push(callback)
 
           return proxy
@@ -118,6 +119,10 @@ export default class CommandManager {
     const { editor, commands } = this
     const { state, view } = editor
 
+    if (state.storedMarks) {
+      tr.setStoredMarks(state.storedMarks)
+    }
+
     const props = {
       tr,
       editor,
@@ -141,6 +146,10 @@ export default class CommandManager {
   }
 
   public chainableState(tr: Transaction, state: EditorState): EditorState {
+    let { selection } = tr
+    let { doc } = tr
+    let { storedMarks } = tr
+
     return {
       ...state,
       schema: state.schema,
@@ -150,15 +159,19 @@ export default class CommandManager {
       reconfigure: state.reconfigure.bind(state),
       toJSON: state.toJSON.bind(state),
       get storedMarks() {
-        return tr.storedMarks
+        return storedMarks
       },
       get selection() {
-        return tr.selection
+        return selection
       },
       get doc() {
-        return tr.doc
+        return doc
       },
       get tr() {
+        selection = tr.selection
+        doc = tr.doc
+        storedMarks = tr.storedMarks
+
         return tr
       },
     }

From 1513f8ccc29287805b5ad1c5cd83be5e05d869b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Tue, 1 Dec 2020 23:45:01 +0100
Subject: [PATCH 4/7] improve toc demo

---
 .../Guide/NodeViews/TableOfContents/Component.vue      |  2 ++
 .../demos/Guide/NodeViews/TableOfContents/index.vue    | 10 +++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/docs/src/demos/Guide/NodeViews/TableOfContents/Component.vue b/docs/src/demos/Guide/NodeViews/TableOfContents/Component.vue
index 85a9933f..f67c09fe 100644
--- a/docs/src/demos/Guide/NodeViews/TableOfContents/Component.vue
+++ b/docs/src/demos/Guide/NodeViews/TableOfContents/Component.vue
@@ -63,7 +63,9 @@ export default {
     margin-top: 0.75em;
   }
 }
+</style>
 
+<style lang="scss" scoped>
 .toc {
   opacity: 0.75;
   border-radius: 0.5rem;
diff --git a/docs/src/demos/Guide/NodeViews/TableOfContents/index.vue b/docs/src/demos/Guide/NodeViews/TableOfContents/index.vue
index 68012810..b39c6432 100644
--- a/docs/src/demos/Guide/NodeViews/TableOfContents/index.vue
+++ b/docs/src/demos/Guide/NodeViews/TableOfContents/index.vue
@@ -27,15 +27,15 @@ export default {
       ],
       content: `
         <toc></toc>
-        <h2>heading</h2>
+        <h2>1 heading</h2>
         <p>paragraph</p>
-        <h3>heading</h3>
+        <h3>1.1 heading</h3>
         <p>paragraph</p>
-        <h3>heading</h3>
+        <h3>1.2 heading</h3>
         <p>paragraph</p>
-        <h2>heading</h2>
+        <h2>2 heading</h2>
         <p>paragraph</p>
-        <h3>heading</h3>
+        <h3>2.1 heading</h3>
         <p>paragraph</p>
       `,
     })

From 5b794c91371589f7603a2e6456c800cea9b20033 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Wed, 2 Dec 2020 08:55:34 +0100
Subject: [PATCH 5/7] improve isActive

---
 packages/core/src/helpers/isMarkActive.ts | 2 +-
 packages/core/src/helpers/isNodeActive.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/core/src/helpers/isMarkActive.ts b/packages/core/src/helpers/isMarkActive.ts
index af0ffd37..f276670f 100644
--- a/packages/core/src/helpers/isMarkActive.ts
+++ b/packages/core/src/helpers/isMarkActive.ts
@@ -65,5 +65,5 @@ export default function isMarkActive(
       return sum + size
     }, 0)
 
-  return selectionRange === range
+  return range >= selectionRange
 }
diff --git a/packages/core/src/helpers/isNodeActive.ts b/packages/core/src/helpers/isNodeActive.ts
index fe78c93b..082df635 100644
--- a/packages/core/src/helpers/isNodeActive.ts
+++ b/packages/core/src/helpers/isNodeActive.ts
@@ -63,5 +63,5 @@ export default function isNodeActive(
       return sum + size
     }, 0)
 
-  return selectionRange === range
+  return range >= selectionRange
 }

From 143b309bdff380db31ecee5fca31a6117d9186c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Wed, 2 Dec 2020 09:28:55 +0100
Subject: [PATCH 6/7] add collab commands

---
 packages/core/src/CommandManager.ts           |  6 ++--
 packages/extension-collaboration/src/index.ts | 35 ++++++++++++++-----
 2 files changed, 30 insertions(+), 11 deletions(-)

diff --git a/packages/core/src/CommandManager.ts b/packages/core/src/CommandManager.ts
index c41dcb1f..b0e8ad7e 100644
--- a/packages/core/src/CommandManager.ts
+++ b/packages/core/src/CommandManager.ts
@@ -53,7 +53,9 @@ export default class CommandManager {
         const method = (...args: any) => {
           const callback = command(...args)(props)
 
-          view.dispatch(tr)
+          if (tr.steps.length) {
+            view.dispatch(tr)
+          }
 
           return callback
         }
@@ -72,7 +74,7 @@ export default class CommandManager {
     return new Proxy({}, {
       get: (_, name: string, proxy) => {
         if (name === 'run') {
-          if (!hasStartTransaction && shouldDispatch) {
+          if (!hasStartTransaction && shouldDispatch && tr.steps.length) {
             view.dispatch(tr)
           }
 
diff --git a/packages/extension-collaboration/src/index.ts b/packages/extension-collaboration/src/index.ts
index 6249c4bb..63f775df 100644
--- a/packages/extension-collaboration/src/index.ts
+++ b/packages/extension-collaboration/src/index.ts
@@ -1,4 +1,4 @@
-import { Extension } from '@tiptap/core'
+import { Extension, Command } from '@tiptap/core'
 import {
   redo,
   undo,
@@ -15,6 +15,31 @@ const Collaboration = Extension.create({
     provider: null,
   },
 
+  addCommands() {
+    return {
+      /**
+       * Undo recent changes
+       */
+      undo: (): Command => ({ state }) => {
+        return undo(state)
+      },
+      /**
+       * Reapply reverted changes
+       */
+      redo: (): Command => ({ state }) => {
+        return redo(state)
+      },
+    }
+  },
+
+  addKeyboardShortcuts() {
+    return {
+      'Mod-z': () => this.editor.commands.undo(),
+      'Mod-y': () => this.editor.commands.redo(),
+      'Shift-Mod-z': () => this.editor.commands.redo(),
+    }
+  },
+
   addProseMirrorPlugins() {
     return [
       ySyncPlugin(
@@ -24,14 +49,6 @@ const Collaboration = Extension.create({
     ]
   },
 
-  addKeyboardShortcuts() {
-    return {
-      'Mod-z': () => undo(this.editor.state),
-      'Mod-y': () => redo(this.editor.state),
-      'Mod-Shift-z': () => redo(this.editor.state),
-    }
-  },
-
   onDestroy() {
     this.options.provider?.destroy()
   },

From 88f89df479da665339cce7a04db755b3d06b86c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Wed, 2 Dec 2020 09:44:46 +0100
Subject: [PATCH 7/7] extension name is required now

---
 packages/core/src/Extension.ts                       | 2 +-
 packages/core/src/extensions/commands.ts             | 2 ++
 packages/core/src/extensions/editable.ts             | 2 ++
 packages/core/src/extensions/focusEvents.ts          | 2 ++
 packages/core/src/extensions/keymap.ts               | 2 ++
 packages/extension-collaboration-cursor/src/index.ts | 2 ++
 packages/extension-collaboration/src/index.ts        | 2 ++
 packages/extension-dropcursor/src/index.ts           | 2 ++
 packages/extension-focus/src/index.ts                | 2 ++
 packages/extension-font-family/src/index.ts          | 2 ++
 packages/extension-gapcursor/src/index.ts            | 2 ++
 packages/extension-text-align/src/index.ts           | 2 ++
 packages/extension-typography/src/index.ts           | 2 ++
 13 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/packages/core/src/Extension.ts b/packages/core/src/Extension.ts
index 725f6ce0..ac38d3c7 100644
--- a/packages/core/src/Extension.ts
+++ b/packages/core/src/Extension.ts
@@ -7,7 +7,7 @@ export interface ExtensionConfig<Options = any, Commands = {}> {
   /**
    * Name
    */
-  name?: string,
+  name: string,
 
   /**
    * Default options
diff --git a/packages/core/src/extensions/commands.ts b/packages/core/src/extensions/commands.ts
index 2f374c91..15ca07fd 100644
--- a/packages/core/src/extensions/commands.ts
+++ b/packages/core/src/extensions/commands.ts
@@ -32,6 +32,8 @@ import * as wrapIn from '../commands/wrapIn'
 import * as wrapInList from '../commands/wrapInList'
 
 export const Commands = Extension.create({
+  name: 'commands',
+
   addCommands() {
     return {
       ...blur,
diff --git a/packages/core/src/extensions/editable.ts b/packages/core/src/extensions/editable.ts
index 4dc9f2d0..7e70245e 100644
--- a/packages/core/src/extensions/editable.ts
+++ b/packages/core/src/extensions/editable.ts
@@ -2,6 +2,8 @@ import { Plugin, PluginKey } from 'prosemirror-state'
 import { Extension } from '../Extension'
 
 export const Editable = Extension.create({
+  name: 'editable',
+
   addProseMirrorPlugins() {
     return [
       new Plugin({
diff --git a/packages/core/src/extensions/focusEvents.ts b/packages/core/src/extensions/focusEvents.ts
index fad279e6..8dd43a4e 100644
--- a/packages/core/src/extensions/focusEvents.ts
+++ b/packages/core/src/extensions/focusEvents.ts
@@ -2,6 +2,8 @@ import { Plugin, PluginKey } from 'prosemirror-state'
 import { Extension } from '../Extension'
 
 export const FocusEvents = Extension.create({
+  name: 'focusEvents',
+
   addProseMirrorPlugins() {
     const { editor } = this
 
diff --git a/packages/core/src/extensions/keymap.ts b/packages/core/src/extensions/keymap.ts
index 4b28f6e2..330f9a44 100644
--- a/packages/core/src/extensions/keymap.ts
+++ b/packages/core/src/extensions/keymap.ts
@@ -13,6 +13,8 @@ import { undoInputRule } from 'prosemirror-inputrules'
 import { Extension } from '../Extension'
 
 export const Keymap = Extension.create({
+  name: 'keymap',
+
   addKeyboardShortcuts() {
     const handleBackspace = () => this.editor.commands.first(({ state, dispatch }) => [
       () => undoInputRule(state, dispatch),
diff --git a/packages/extension-collaboration-cursor/src/index.ts b/packages/extension-collaboration-cursor/src/index.ts
index 785a2e1f..d44e33b0 100644
--- a/packages/extension-collaboration-cursor/src/index.ts
+++ b/packages/extension-collaboration-cursor/src/index.ts
@@ -18,6 +18,8 @@ const awarenessStatesToArray = (states: Map<number, { [key: string]: any }>) =>
 }
 
 const CollaborationCursor = Extension.create({
+  name: 'collaborationCursor',
+
   defaultOptions: <CollaborationCursorOptions>{
     provider: null,
     user: {
diff --git a/packages/extension-collaboration/src/index.ts b/packages/extension-collaboration/src/index.ts
index 63f775df..ab7b7250 100644
--- a/packages/extension-collaboration/src/index.ts
+++ b/packages/extension-collaboration/src/index.ts
@@ -11,6 +11,8 @@ export interface CollaborationOptions {
 }
 
 const Collaboration = Extension.create({
+  name: 'collaboration',
+
   defaultOptions: <CollaborationOptions>{
     provider: null,
   },
diff --git a/packages/extension-dropcursor/src/index.ts b/packages/extension-dropcursor/src/index.ts
index c9cdf8a1..fa677a23 100644
--- a/packages/extension-dropcursor/src/index.ts
+++ b/packages/extension-dropcursor/src/index.ts
@@ -8,6 +8,8 @@ export interface DropcursorOptions {
 }
 
 const Dropcursor = Extension.create({
+  name: 'dropCursor',
+
   defaultOptions: <DropcursorOptions>{
     color: 'black',
     width: 1,
diff --git a/packages/extension-focus/src/index.ts b/packages/extension-focus/src/index.ts
index 62c7844c..b15ee7e0 100644
--- a/packages/extension-focus/src/index.ts
+++ b/packages/extension-focus/src/index.ts
@@ -8,6 +8,8 @@ export interface FocusOptions {
 }
 
 const FocusClasses = Extension.create({
+  name: 'focus',
+
   defaultOptions: <FocusOptions>{
     className: 'has-focus',
     nested: false,
diff --git a/packages/extension-font-family/src/index.ts b/packages/extension-font-family/src/index.ts
index 629f45b2..afe5b059 100644
--- a/packages/extension-font-family/src/index.ts
+++ b/packages/extension-font-family/src/index.ts
@@ -6,6 +6,8 @@ type FontFamilyOptions = {
 }
 
 const FontFamily = Extension.create({
+  name: 'fontFamily',
+
   defaultOptions: <FontFamilyOptions>{
     types: ['textStyle'],
   },
diff --git a/packages/extension-gapcursor/src/index.ts b/packages/extension-gapcursor/src/index.ts
index 09ee3846..b22ab6f3 100644
--- a/packages/extension-gapcursor/src/index.ts
+++ b/packages/extension-gapcursor/src/index.ts
@@ -2,6 +2,8 @@ import { Extension } from '@tiptap/core'
 import { gapCursor } from 'prosemirror-gapcursor'
 
 const Gapcursor = Extension.create({
+  name: 'gapCursor',
+
   addProseMirrorPlugins() {
     return [
       gapCursor(),
diff --git a/packages/extension-text-align/src/index.ts b/packages/extension-text-align/src/index.ts
index 6a9b1ffe..2722da5b 100644
--- a/packages/extension-text-align/src/index.ts
+++ b/packages/extension-text-align/src/index.ts
@@ -7,6 +7,8 @@ type TextAlignOptions = {
 }
 
 const TextAlign = Extension.create({
+  name: 'textAlign',
+
   defaultOptions: <TextAlignOptions>{
     types: ['heading', 'paragraph'],
     alignments: ['left', 'center', 'right', 'justify'],
diff --git a/packages/extension-typography/src/index.ts b/packages/extension-typography/src/index.ts
index 34e696c4..820e472e 100644
--- a/packages/extension-typography/src/index.ts
+++ b/packages/extension-typography/src/index.ts
@@ -21,6 +21,8 @@ export const raquo = new InputRule(/>>$/, '»')
 export const multiplication = new InputRule(/\d+\s?([*x])\s?\d+$/, '×')
 
 const Typography = Extension.create({
+  name: 'typography',
+
   addInputRules() {
     return [
       emDash,