ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: fix focus on iOS, fix #1806

Browse Source
This commit is contained in:
Philipp Kühn
2021-08-26 22:32:32 +02:00
parent 83e2d4d3e2
commit 3a0693869d
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/src/commands/focus.ts
View File

@@ -2,6 +2,7 @@ import { EditorState, Selection, TextSelection } from 'prosemirror-state'
import { RawCommands, FocusPosition } from '../types' import { RawCommands, FocusPosition } from '../types'
import minMax from '../utilities/minMax' import minMax from '../utilities/minMax'
import isTextSelection from '../helpers/isTextSelection' import isTextSelection from '../helpers/isTextSelection'
import isiOS from '../utilities/isiOS'
function resolveSelection(state: EditorState, position: FocusPosition = null) { function resolveSelection(state: EditorState, position: FocusPosition = null) {
if (!position) { if (!position) {
@@ -48,11 +49,18 @@ export const focus: RawCommands['focus'] = (position = null) => ({
dispatch, dispatch,
}) => { }) => {
const delayedFocus = () => { const delayedFocus = () => {
// focus within `requestAnimationFrame` breaks focus on iOS
// so we have to call this
if (isiOS()) {
(view.dom as HTMLElement).focus()
}
// For React we have to focus asynchronously. Otherwise wild things happen. // For React we have to focus asynchronously. Otherwise wild things happen.
// see: https://github.com/ueberdosis/tiptap/issues/1520 // see: https://github.com/ueberdosis/tiptap/issues/1520
requestAnimationFrame(() => { requestAnimationFrame(() => {
if (!editor.isDestroyed) { if (!editor.isDestroyed) {
view.focus() view.focus()
editor.commands.scrollIntoView()
} }
}) })
} }