ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(core): setNodeSelection should not clamp pos by Selection.atStart/atEnd (#3091)

Browse Source 
Fixes #3090.
This commit is contained in:
Asherah Connor
2022-08-22 22:22:44 +10:00
committed by GitHub
parent cc1395a7a4
commit 313b8b8d0a
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/src/commands/setNodeSelection.ts
View File

@@ -1,4 +1,4 @@
import { NodeSelection, Selection } from 'prosemirror-state' import { NodeSelection } from 'prosemirror-state'
import { RawCommands } from '../types' import { RawCommands } from '../types'
import { minMax } from '../utilities/minMax' import { minMax } from '../utilities/minMax'
@@ -17,10 +17,8 @@ declare module '@tiptap/core' {
export const setNodeSelection: RawCommands['setNodeSelection'] = position => ({ tr, dispatch }) => { export const setNodeSelection: RawCommands['setNodeSelection'] = position => ({ tr, dispatch }) => {
if (dispatch) { if (dispatch) {
const { doc } = tr const { doc } = tr
const minPos = Selection.atStart(doc).from const from = minMax(position, 0, doc.content.size)
const maxPos = Selection.atEnd(doc).to const selection = NodeSelection.create(doc, from)
const resolvedPos = minMax(position, minPos, maxPos)
const selection = NodeSelection.create(doc, resolvedPos)
tr.setSelection(selection) tr.setSelection(selection)
} }