From 2c52f0ce06d7cf3dd1071d8ba5bfbbe33c4a267a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Tue, 27 Oct 2020 11:54:58 +0100
Subject: [PATCH] dont use data- attributes as default

---
 packages/core/src/utils/getRenderedAttributes.ts     |  2 +-
 .../utils/injectExtensionAttributesToParseRule.ts    |  2 +-
 packages/extension-link/index.ts                     | 12 ------------
 3 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/packages/core/src/utils/getRenderedAttributes.ts b/packages/core/src/utils/getRenderedAttributes.ts
index f50f0dde..a98138c5 100644
--- a/packages/core/src/utils/getRenderedAttributes.ts
+++ b/packages/core/src/utils/getRenderedAttributes.ts
@@ -8,7 +8,7 @@ export default function getRenderedAttributes(nodeOrMark: Node | Mark, extension
     .map(item => {
       if (!item.attribute.renderHTML) {
         return {
-          [`data-${item.name}`]: nodeOrMark.attrs[item.name],
+          [item.name]: nodeOrMark.attrs[item.name],
         }
       }
 
diff --git a/packages/core/src/utils/injectExtensionAttributesToParseRule.ts b/packages/core/src/utils/injectExtensionAttributesToParseRule.ts
index 0934c480..de74cedf 100644
--- a/packages/core/src/utils/injectExtensionAttributesToParseRule.ts
+++ b/packages/core/src/utils/injectExtensionAttributesToParseRule.ts
@@ -23,7 +23,7 @@ export default function injectExtensionAttributesToParseRule(parseRule: ParseRul
           const attributes = item.attribute.parseHTML
             ? item.attribute.parseHTML(node as HTMLElement)
             : {
-              [item.name]: (node as HTMLElement).dataset[item.name],
+              [item.name]: (node as HTMLElement).getAttribute(item.name),
             }
 
           const filteredAttributes = Object.fromEntries(Object.entries(attributes)
diff --git a/packages/extension-link/index.ts b/packages/extension-link/index.ts
index 40659e34..5e3aaf77 100644
--- a/packages/extension-link/index.ts
+++ b/packages/extension-link/index.ts
@@ -26,21 +26,9 @@ const Link = createMark({
     return {
       href: {
         default: null,
-        renderHTML: attributes => ({
-          href: attributes.href,
-        }),
-        parseHTML: node => ({
-          href: node.getAttribute('href'),
-        }),
       },
       target: {
         default: this.options.target,
-        renderHTML: attributes => ({
-          target: attributes.target,
-        }),
-        parseHTML: node => ({
-          target: node.getAttribute('target'),
-        }),
       },
     }
   },