ianhitchman/tiptap
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix nodeview type, fix #92

Browse Source
This commit is contained in:
Philipp Kühn
2021-01-13 09:09:56 +01:00
parent ecd0a6669a
commit 21b2d422fb
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/types.ts
View File

@@ -97,7 +97,7 @@ export type NodeViewRendererProps = {
extension: Node, extension: Node,
} }
export type NodeViewRenderer = (props: NodeViewRendererProps) => NodeView export type NodeViewRenderer = (props: NodeViewRendererProps) => (NodeView | undefined)
export type UnfilteredCommands = { export type UnfilteredCommands = {
[Item in keyof AllExtensions]: AllExtensions[Item] extends Extension<any, infer ExtensionCommands> [Item in keyof AllExtensions]: AllExtensions[Item] extends Extension<any, infer ExtensionCommands>

9
packages/vue/src/VueRenderer.ts
View File

@@ -1,4 +1,9 @@
import { Editor, Node, NodeViewRendererProps } from '@tiptap/core' import {
Editor,
Node,
NodeViewRenderer,
NodeViewRendererProps,
} from '@tiptap/core'
import { Decoration, NodeView } from 'prosemirror-view' import { Decoration, NodeView } from 'prosemirror-view'
import { NodeSelection } from 'prosemirror-state' import { NodeSelection } from 'prosemirror-state'
import { Node as ProseMirrorNode } from 'prosemirror-model' import { Node as ProseMirrorNode } from 'prosemirror-model'
@@ -309,7 +314,7 @@ class VueNodeView implements NodeView {
} }
export default function VueRenderer(component: Vue | VueConstructor, options?: Partial<VueRendererOptions>) { export default function VueRenderer(component: Vue | VueConstructor, options?: Partial<VueRendererOptions>): NodeViewRenderer {
return (props: NodeViewRendererProps) => { return (props: NodeViewRendererProps) => {
// try to get the parent component // try to get the parent component
// this is important for vue devtools to show the component hierarchy correctly // this is important for vue devtools to show the component hierarchy correctly