refactoring

packages/tiptap/src/Components/EditorFloatingMenu.js

@@ -43,7 +43,7 @@ export default {
       focus: this.editor.focus,
       commands: this.editor.commands,
       isActive: this.editor.isActive,
-      markAttrs: this.editor.markAttrs.bind(this.editor),
+      getMarkAttrs: this.editor.getMarkAttrs.bind(this.editor),
       menu: this.menu,
     })
   },

packages/tiptap/src/Components/EditorMenuBar.js

@@ -15,7 +15,7 @@ export default {
       focus: this.editor.focus,
       commands: this.editor.commands,
       isActive: this.editor.isActive,
-      markAttrs: this.editor.markAttrs.bind(this.editor),
+      getMarkAttrs: this.editor.getMarkAttrs.bind(this.editor),
     })
   },
 }

packages/tiptap/src/Components/EditorMenuBubble.js

@@ -43,7 +43,7 @@ export default {
       focus: this.editor.focus,
       commands: this.editor.commands,
       isActive: this.editor.isActive,
-      markAttrs: this.editor.markAttrs.bind(this.editor),
+      getMarkAttrs: this.editor.getMarkAttrs.bind(this.editor),
       menu: this.menu,
     })
   },

packages/tiptap/src/utils/Editor.js

@@ -280,23 +280,20 @@ export default class Editor {
     }
   }
 
-  markAttrs(type = null) {
+  getMarkAttrs(type = null) {
     return this.activeMarkAttrs[type]
   }
 
   get isActive() {
-    const types = {
-      ...this.activeMarks,
-      ...this.activeNodes,
-    }
-
-    Object
-      .entries(types)
-      .forEach(([name, value]) => {
-        types[name] = (attrs = {}) => value(attrs)
+    return Object
+      .entries({
+        ...this.activeMarks,
+        ...this.activeNodes,
       })
-
-    return types
+      .reduce((types, [name, value]) => ({
+        ...types,
+        [name]: (attrs = {}) => value(attrs),
+      }), {})
   }
 
   destroy() {