From 012beb286c1fc0c97feb7f1cced8b9688a202c86 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Ku=CC=88hn?= <kontakt@philipp-kuehn.com>
Date: Wed, 18 Nov 2020 11:54:18 +0100
Subject: [PATCH] add blockquote commands

---
 docs/src/demos/Examples/Basic/index.vue          |  2 +-
 .../Examples/CollaborativeEditing/index.vue      |  2 +-
 .../Examples/CollaborativeEditingWs/index.vue    |  2 +-
 docs/src/demos/Nodes/Blockquote/index.vue        |  2 +-
 packages/core/src/commands/lift.ts               | 16 ++++++++++++++++
 packages/core/src/commands/toggleWrap.ts         |  6 +++---
 packages/core/src/commands/wrapIn.ts             | 16 ++++++++++++++++
 packages/core/src/extensions/commands.ts         | 10 ++++++++++
 packages/extension-blockquote/src/index.ts       | 16 ++++++++++++++--
 9 files changed, 63 insertions(+), 9 deletions(-)
 create mode 100644 packages/core/src/commands/lift.ts
 create mode 100644 packages/core/src/commands/wrapIn.ts

diff --git a/docs/src/demos/Examples/Basic/index.vue b/docs/src/demos/Examples/Basic/index.vue
index 1f999876..e37494a9 100644
--- a/docs/src/demos/Examples/Basic/index.vue
+++ b/docs/src/demos/Examples/Basic/index.vue
@@ -49,7 +49,7 @@
       <button @click="editor.chain().focus().codeBlock().run()" :class="{ 'is-active': editor.isActive('codeBlock') }">
         code block
       </button>
-      <button @click="editor.chain().focus().blockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
+      <button @click="editor.chain().focus().toggleBlockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
         blockquote
       </button>
       <button @click="editor.chain().focus().horizontalRule().run()">
diff --git a/docs/src/demos/Examples/CollaborativeEditing/index.vue b/docs/src/demos/Examples/CollaborativeEditing/index.vue
index be505434..eb03cf0a 100644
--- a/docs/src/demos/Examples/CollaborativeEditing/index.vue
+++ b/docs/src/demos/Examples/CollaborativeEditing/index.vue
@@ -49,7 +49,7 @@
       <button @click="editor.chain().focus().codeBlock().run()" :class="{ 'is-active': editor.isActive('codeBlock') }">
         code block
       </button>
-      <button @click="editor.chain().focus().blockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
+      <button @click="editor.chain().focus().toggleBlockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
         blockquote
       </button>
       <button @click="editor.chain().focus().horizontalRule().run()">
diff --git a/docs/src/demos/Examples/CollaborativeEditingWs/index.vue b/docs/src/demos/Examples/CollaborativeEditingWs/index.vue
index 9a2b63e7..e186a45f 100644
--- a/docs/src/demos/Examples/CollaborativeEditingWs/index.vue
+++ b/docs/src/demos/Examples/CollaborativeEditingWs/index.vue
@@ -49,7 +49,7 @@
       <button @click="editor.chain().focus().codeBlock().run()" :class="{ 'is-active': editor.isActive('codeBlock') }">
         code block
       </button>
-      <button @click="editor.chain().focus().blockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
+      <button @click="editor.chain().focus().toggleBlockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
         blockquote
       </button>
       <button @click="editor.chain().focus().horizontalRule().run()">
diff --git a/docs/src/demos/Nodes/Blockquote/index.vue b/docs/src/demos/Nodes/Blockquote/index.vue
index 15148420..e8c6d2b1 100644
--- a/docs/src/demos/Nodes/Blockquote/index.vue
+++ b/docs/src/demos/Nodes/Blockquote/index.vue
@@ -1,6 +1,6 @@
 <template>
   <div v-if="editor">
-    <button @click="editor.chain().focus().blockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
+    <button @click="editor.chain().focus().toggleBlockquote().run()" :class="{ 'is-active': editor.isActive('blockquote') }">
       blockquote
     </button>
 
diff --git a/packages/core/src/commands/lift.ts b/packages/core/src/commands/lift.ts
new file mode 100644
index 00000000..f9594247
--- /dev/null
+++ b/packages/core/src/commands/lift.ts
@@ -0,0 +1,16 @@
+import { lift } from 'prosemirror-commands'
+import { NodeType } from 'prosemirror-model'
+import { Command } from '../types'
+import nodeIsActive from '../utils/nodeIsActive'
+import getNodeType from '../utils/getNodeType'
+
+export default (typeOrName: string | NodeType, attributes = {}): Command => ({ state, dispatch }) => {
+  const type = getNodeType(typeOrName, state.schema)
+  const isActive = nodeIsActive(state, type, attributes)
+
+  if (!isActive) {
+    return false
+  }
+
+  return lift(state, dispatch)
+}
diff --git a/packages/core/src/commands/toggleWrap.ts b/packages/core/src/commands/toggleWrap.ts
index c72dd0a5..72b45848 100644
--- a/packages/core/src/commands/toggleWrap.ts
+++ b/packages/core/src/commands/toggleWrap.ts
@@ -4,13 +4,13 @@ import { Command } from '../types'
 import nodeIsActive from '../utils/nodeIsActive'
 import getNodeType from '../utils/getNodeType'
 
-export default (typeOrName: string | NodeType, attrs = {}): Command => ({ state, dispatch }) => {
+export default (typeOrName: string | NodeType, attributes = {}): Command => ({ state, dispatch }) => {
   const type = getNodeType(typeOrName, state.schema)
-  const isActive = nodeIsActive(state, type, attrs)
+  const isActive = nodeIsActive(state, type, attributes)
 
   if (isActive) {
     return lift(state, dispatch)
   }
 
-  return wrapIn(type, attrs)(state, dispatch)
+  return wrapIn(type, attributes)(state, dispatch)
 }
diff --git a/packages/core/src/commands/wrapIn.ts b/packages/core/src/commands/wrapIn.ts
new file mode 100644
index 00000000..9d1b2d75
--- /dev/null
+++ b/packages/core/src/commands/wrapIn.ts
@@ -0,0 +1,16 @@
+import { wrapIn } from 'prosemirror-commands'
+import { NodeType } from 'prosemirror-model'
+import { Command } from '../types'
+import nodeIsActive from '../utils/nodeIsActive'
+import getNodeType from '../utils/getNodeType'
+
+export default (typeOrName: string | NodeType, attributes = {}): Command => ({ state, dispatch }) => {
+  const type = getNodeType(typeOrName, state.schema)
+  const isActive = nodeIsActive(state, type, attributes)
+
+  if (isActive) {
+    return false
+  }
+
+  return wrapIn(type, attributes)(state, dispatch)
+}
diff --git a/packages/core/src/extensions/commands.ts b/packages/core/src/extensions/commands.ts
index f10b2701..9d647dc2 100644
--- a/packages/core/src/extensions/commands.ts
+++ b/packages/core/src/extensions/commands.ts
@@ -9,6 +9,7 @@ import extendMarkRange from '../commands/extendMarkRange'
 import focus from '../commands/focus'
 import insertHTML from '../commands/insertHTML'
 import insertText from '../commands/insertText'
+import lift from '../commands/lift'
 import liftListItem from '../commands/liftListItem'
 import removeMark from '../commands/removeMark'
 import removeMarks from '../commands/removeMarks'
@@ -27,6 +28,7 @@ import toggleMark from '../commands/toggleMark'
 import toggleWrap from '../commands/toggleWrap'
 import tryCommand from '../commands/try'
 import updateNodeAttributes from '../commands/updateNodeAttributes'
+import wrapIn from '../commands/wrapIn'
 import wrapInList from '../commands/wrapInList'
 
 export const Commands = Extension.create({
@@ -72,6 +74,10 @@ export const Commands = Extension.create({
        * Insert a string of text at the current position.
        */
       insertText,
+      /**
+       * Removes an existing wrap.
+       */
+      lift,
       /**
        * Lift the list item into a wrapping list.
        */
@@ -144,6 +150,10 @@ export const Commands = Extension.create({
        * Update attributes of a node.
        */
       updateNodeAttributes,
+      /**
+       * Wraps nodes in another node.
+       */
+      wrapIn,
       /**
        * Wrap a node in a list.
        */
diff --git a/packages/extension-blockquote/src/index.ts b/packages/extension-blockquote/src/index.ts
index d0d3f318..60ae7c0e 100644
--- a/packages/extension-blockquote/src/index.ts
+++ b/packages/extension-blockquote/src/index.ts
@@ -34,18 +34,30 @@ const Blockquote = Node.create({
 
   addCommands() {
     return {
+      /**
+       * Set a blockquote node
+       */
+      setBlockquote: (): Command => ({ commands }) => {
+        return commands.wrapIn('blockquote')
+      },
       /**
        * Toggle a blockquote node
        */
-      blockquote: (): Command => ({ commands }) => {
+      toggleBlockquote: (): Command => ({ commands }) => {
         return commands.toggleWrap('blockquote')
       },
+      /**
+       * Unset a blockquote node
+       */
+      unsetBlockquote: (): Command => ({ commands }) => {
+        return commands.lift('blockquote')
+      },
     }
   },
 
   addKeyboardShortcuts() {
     return {
-      'Shift-Mod-9': () => this.editor.commands.blockquote(),
+      'Shift-Mod-9': () => this.editor.commands.toggleBlockquote(),
     }
   },